Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove explicit mentionings of MCParticle momentum type #256

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Remove explicit mentionings of MCParticle momentum type #256

merged 1 commit into from
Dec 11, 2023

Conversation

tmadlener
Copy link
Contributor

Remove the explicit mentionings of edm4hep::Vector3f for cases where an auto does the trick. This makes it easier to switch representations while being backwards compatible. This is necessary for key4hep/EDM4hep#237

mirguest
mirguest approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@mirguest mirguest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good to me.

@mirguest mirguest merged commit c508332 into cepc:master Dec 11, 2023
2 checks passed
@tmadlener tmadlener mentioned this pull request Dec 11, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirguest mirguest mirguest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmadlener @mirguest