Make MCParticle momenta use doubles instead of floats #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do we need real doubles here or should we consider something like ROOTs Double32_t which would have the same behaviour as it had in the lcio world i.e. 64 bit in memory 32 bit on disk? |
|
But |
|
yes we would need to put the logic for that somewhere I guess |
This was referenced Dec 11, 2023
tmadlener
force-pushed
the
mcparticles-double-momentum
branch
from
38ec258
to
3c62601
Compare
tmadlener
changed the title
tmadlener
force-pushed
the
mcparticles-double-momentum
branch
from
383c5ab
to
9e1ddfd
Compare
tmadlener
force-pushed
the
mcparticles-double-momentum
branch
from
9e1ddfd
to
a7b0fd3
Compare
This direction should not suffer from narrowing
tmadlener
force-pushed
the
mcparticles-double-momentum
branch
from
a7b0fd3
to
b72ed3e
Compare
tmadlener
commented
Jan 23, 2024
jmcarcell
added a commit
that referenced
this pull request
Jan 29, 2024
…a use doubles instead of floats (#237)
tmadlener
added a commit
that referenced
this pull request
Feb 7, 2024
tmadlener
added a commit
to tmadlener/EDM4hep
that referenced
this pull request
Feb 8, 2024
* Make momentum use doubles instead of floats * Fix python unittests * Add a constructor from Vector3f for Vector3d This direction should not suffer from narrowing
tmadlener
added a commit
that referenced
this pull request
Feb 8, 2024
* Make momentum use doubles instead of floats * Fix python unittests * Add a constructor from Vector3f for Vector3d This direction should not suffer from narrowing
tmadlener
added a commit
that referenced
this pull request
Feb 13, 2024
* Make momentum use doubles instead of floats * Fix python unittests * Add a constructor from Vector3f for Vector3d This direction should not suffer from narrowing
jmcarcell
pushed a commit
to tmadlener/EDM4hep
that referenced
this pull request
Feb 22, 2024
* Make momentum use doubles instead of floats * Fix python unittests * Add a constructor from Vector3f for Vector3d This direction should not suffer from narrowing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
momentumandmomentumAtEndpointof theMCParticlefromVector3ftoVector3d.Vector3ftoVector3dto ease the transition.ENDRELEASENOTES
As (partially) discussed in #208
This breaks building (at least the following):