Create "ceph-nvmeof" CLI command to use nvmeof-cli

[VallariAg]

Add "ceph-nvmeof" cli command to package this as python cli tool instead of using via containers.

How to build it:

git clone https://github.com/ceph/ceph-nvmeof.git
cd ceph-nvmeof/
dnf install -y python3-pip
python3 -m venv venv
source venv/bin/activate
pip install -U pip setuptools
pip install pdm==2.7.4
pdm "sync" -v --no-isolation --no-self --no-editable
pdm run protoc
pdm build

pip install dist/ceph_nvmeof-1.2.15-py3-none-any.whl
ceph-nvmeof

Usage:

[root@singleESXiS1in ~]# pip3 install ceph-nvmeof
[root@singleESXiS1in ~]# ceph-nvmeof --server-address $NVMEOF_DEFAULT_GATEWAY_IP_ADDRESS --server-port $NVMEOF_SRPORT --format json subsystem list
{
    "error_message": "Success",
    "status": 0,
    "subsystems": []
}
[root@singleESXiS1in ~]# ceph-nvmeof  --server-address $NVMEOF_DEFAULT_GATEWAY_IP_ADDRESS --server-port $NVMEOF_SRPORT subsystem add --subsystem nqn.2016-06.io.spdk:cnode1
Adding subsystem nqn.2016-06.io.spdk:cnode1: Successful
[root@singleESXiS1in ~]# ceph-nvmeof --server-address $NVMEOF_DEFAULT_GATEWAY_IP_ADDRESS --server-port $NVMEOF_SRPORT --format json subsystem list
{
    "error_message": "Success",
    "subsystems": [
        {
            "nqn": "nqn.2016-06.io.spdk:cnode1",
            "enable_ha": true,
            "serial_number": "Ceph36100720827891",
            "model_number": "Ceph bdev Controller",
            "min_cntlid": 1,
            "max_cntlid": 2040,
            "subtype": "NVMe",
            "max_namespaces": 256,
            "namespace_count": 0
        }
    ],
    "status": 0
}

Package: https://pypi.org/project/ceph-nvmeof/

[baum]

lgtm 🖖

[epuertat]

Great work, Vallari! Now I see the new CLI usage, it'd probably make sense to enable fetching the server address/port from a global env. var too (that will save a lot of repetitive input).

CEPH_NVMEOF_SERVER_ADDRESS=192.168.1.20
CEPH_NVMEOF_SERVER_PORT=5500

ceph-nvmeof gateway info

[VallariAg]

@epuertat I have merged the workflows into one - it looks much better now! Thank you!

Let me know if my solution of reading default server-address/port in control/cli.py is okay!

[epuertat]

Great work, @VallariAg ! Thank you for addressing my comments.

Just left a few more comments that might improve the PR.

[epuertat]

LGMT! Great work @VallariAg !