Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create "ceph-nvmeof" CLI command to use nvmeof-cli #752

Merged
merged 4 commits into from
Jul 23, 2024

Commits on Jul 11, 2024

  1. pyproject.toml: add "[project.scripts]" section

    Add "ceph-nvmeof" cli command to use it as a CLI
    instead of containers.
    
    Signed-off-by: Vallari Agrawal <[email protected]>
    VallariAg committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    63b5eab View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Add .github/workflows/release.yml

    Official releases would be published to
    https://pypi.org/project/ceph-nvmeof/
    on every tag releases on github.
    
    Dev releases would be published to
    https://test.pypi.org/project/ceph-nvmeof/
    on every merge to "devel" branch.
    
    Package will override if the version already exists.
    For example, if "1.2.15" already exists on test.pypi
    and the new commit also has same version (in pyproject.toml),
    then that package would be overwritten (by using a bigger
    build number).
    
    Signed-off-by: Vallari Agrawal <[email protected]>
    VallariAg committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    21e72eb View commit details
    Browse the repository at this point in the history
  2. README: add instructions to install ceph-nvmeof cli

    Signed-off-by: Vallari Agrawal <[email protected]>
    VallariAg committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    10b3004 View commit details
    Browse the repository at this point in the history
  3. control/cli.py: read server-address/port defaults from env

    "--server-address" defaults to env variable
    CEPH_NVMEOF_SERVER_ADDRESS (otherwise "localhost").
    
    "--server-port" defaults to env variable
    CEPH_NVMEOF_SERVER_PORT (otherwise 5500).
    
    This is to avoid repetitive inputs. If these
    environment variables are set, we can just do:
    `ceph-nvmeof gw info`.
    (instead of current `ceph-nvmeof --server-address /
    $NVMEOF_SERVER_ADDRESS --server-port /
    $NVMEOF_SERVER_PORT gw info`)
    
    Signed-off-by: Vallari Agrawal <[email protected]>
    VallariAg committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    6f36404 View commit details
    Browse the repository at this point in the history