Fixes to the tests: pymssql, psql, user & group #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebix
force-pushed
the
fix-tests
branch
3 times, most recently
from
cfa3288 to
630422f
Compare
sebix
changed the title
Debian 11 bullseye has Python 3.9 Ubuntu 20.04 has Python 3.8
Using pyupgrade.
fixes certtools#2543 See https://lists.cert.at/pipermail/intelmq-users/2024-December/000474.html for more information.
pymssql there are no wheels for 3.8, needs to be built install required header files fixes certtools#2539
required by tests maybe it was already installed on github actions by default? we can't rely on it, better do it explicitly then it also works on other plattforms, such as act
if the tests already run with an unprivileged user, all is good, but if running as root, intelmq won't be able to un-privilege itself if there's no intelmq user
this specific tests consistently fails when running on GitHub on Python 3.11 but not everywhere else, so ignore it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #2541 - merge the other one first
pymssql there are no wheels for 3.8, needs to be built
install required header files
fixes tests: pymssql (sql output dependency) installation fails #2539
required by tests
maybe it was already installed on github actions by default? we can't
rely on it, better do it explicitly
then it also works on other plattforms, such as act
if the tests already run with an unprivileged user, all is good, but if
running as root, intelmq won't be able to un-privilege itself if there's
no intelmq user