Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENT-9167: Added ci docker scripts for manual and github actions use #1239

Merged
merged 2 commits into from
Jul 28, 2023
Merged

ENT-9167: Added ci docker scripts for manual and github actions use #1239

merged 2 commits into from
Jul 28, 2023

Conversation

craigcomstock
Copy link
Contributor

@craigcomstock craigcomstock commented Jul 20, 2023 •
edited
Loading

@cf-bottom
Copy link

Thanks for submitting a pull request! Maybe @Lex-2008 can review this?

@craigcomstock craigcomstock mentioned this pull request Jul 27, 2023
Closed
@craigcomstock
Copy link
Contributor Author

@Lex-2008 I switched to this PR in-repo so that the workflow can run. Should be nearly the same as what you already reviewed. :)

@craigcomstock
Copy link
Contributor Author

@cf-bottom jenkins

@cf-bottom
Copy link

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/9649/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-9649/

Lex-2008
Lex-2008 reviewed Jul 28, 2023
View reviewed changes
ci/docker.sh Outdated Show resolved Hide resolved
Lex-2008
Lex-2008 previously approved these changes Jul 28, 2023
View reviewed changes
@craigcomstock
Copy link
Contributor Author

CI failure is a timing flake. Will correct one debug chunk and then we can merge this and https://github.com/cfengine/mission-portal/pull/1996

@craigcomstock
Added ci scripts using docker for github actions
eb0d49f 
Includes unused build-scripts/clean-dependencies which I found helpful while iterating locally.

Ticket: ENT-9167
Changelog: none
@craigcomstock
Fixed non-working source URL for attr dependency
437b108 
Ticket: ENT-9167
Changelog: none
@craigcomstock craigcomstock merged commit 1d551d2 into master Jul 28, 2023
1 check passed
@craigcomstock craigcomstock deleted the ENT-9167/master branch July 28, 2023 14:40
@craigcomstock
Copy link
Contributor Author

cherry picks to
3.18.x: #1244
3.21.x: #1245

They might need some adjustments/fixes for github cache naming due to branch instead of master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lex-2008 Lex-2008 Lex-2008 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@craigcomstock @cf-bottom @Lex-2008