Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add newer class for purging policies #103

Closed
wants to merge 1 commit into from
+1 −0
Closed

add newer class for purging policies #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions management/demo/def.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"classes": {
"mpf_augments_control_enabled": ["any"],
"cfengine_internal_purge_policies": ["any"],
"cfengine_internal_purge_policies_disabled": ["any"],
Comment on lines 4 to +5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"cfengine_internal_purge_policies": ["any"],
"cfengine_internal_purge_policies_disabled": ["any"],

The class cfengine_internal_purge_policies would enable that feature on older versions of the MPF. When this feature was enabled files inside of /var/cfengine/inputs that did not exist on the servers /var/cfengine/masterfiles would be removed from the client, in effect a sync behavior instead of the default to just copy files on top if changes were made, leaving extra files alone.

That default changed and so now that behavior is the default. If you previously had cfengine_internal_purge_policies defined then today you should simply disable the definition of that class to keep that sync behavior. Alternatively, if you desire the old behavior where extra files were not cleaned up then you would instead define cfengine_internal_purge_policies_disabled.

Since, this was enabling that feature which is now the default, I think that both of these should just be removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After thinking about this for a moment another option would be to adjust cfengine_internal_purge_policies to target cfengine_3_18 if the desire is to keep that behavior for older clients that may still be using this. Otherwise, still best to remove both i think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed. I didn't read things quite right. Will adjust.

"cfengine_mp_fr_dependencies_auto_install": ["any"]
},
"vars": {
Expand Down
Loading