Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TCCP Feature Flag #8720

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Remove TCCP Feature Flag #8720

merged 2 commits into from
Jan 21, 2025

Conversation

mistergone
Copy link
Member

This PR will remove the code that leaves TCCP as a feature-flag-dependent product.

Changes

  • Change TCCP's views.py to use TemplateView instead of FlaggedTemplateView, etc
  • Remove "TCCP" from flags in base.py

How to test this PR

  1. Make sure http://localhost:8000/consumer-tools/credit-cards/explore-cards/ works as expected!

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code follows the standards laid out in the CFPB development guidelines

@chuckwerner
TCCP Flag Removal
fd79b10 
- Change TCCP's views.py to use TemplateView instead of FlaggedTemplateView, etc
@chuckwerner
- Remove flag from settings/base.py
14dce5e
@mistergone mistergone requested review from higs4281 and wpears January 17, 2025 18:11
@mistergone mistergone added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit 7f00575 Jan 21, 2025
12 checks passed
@mistergone mistergone deleted the tccp-flag branch January 21, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@higs4281 higs4281 higs4281 approved these changes

@wpears wpears Awaiting requested review from wpears

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mistergone @higs4281 @chuckwerner