Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TCCP Feature Flag #8720

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Remove TCCP Feature Flag #8720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd79b10
TCCP Flag Removal
chuckwerner Jan 17, 2025
14dce5e
- Remove flag from settings/base.py
chuckwerner Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions cfgov/cfgov/settings/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,12 +638,6 @@
"PATH_MATCHES_FOR_QUALTRICS": [],
# Whether robots.txt should block all robots, except for Search.gov.
"ROBOTS_TXT_SEARCH_GOV_ONLY": [("environment is", "beta")],
# TCCP credit card finder
"TCCP": [
("environment is", "dev4"),
("environment is", "local"),
("environment is", "test"),
],
}

REGULATIONS_REFERENCE_MAPPING = [
Expand Down
14 changes: 5 additions & 9 deletions cfgov/tccp/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
from django.template.defaultfilters import title
from django.urls import reverse_lazy
from django.utils.functional import cached_property
from django.views.generic import TemplateView

from flags.views import FlaggedTemplateView, FlaggedViewMixin
from rest_framework.exceptions import ValidationError
from rest_framework.generics import ListAPIView, RetrieveAPIView
from rest_framework.renderers import JSONRenderer, TemplateHTMLRenderer
Expand All @@ -22,8 +22,7 @@
from .situations import Situation, SituationSpeedBumps


class LandingPageView(FlaggedTemplateView):
flag_name = "TCCP"
class LandingPageView(TemplateView):
template_name = "tccp/landing_page.html"
heading = "Explore credit cards for your situation"

Expand Down Expand Up @@ -57,8 +56,7 @@ def redirect_to_results(self, credit_tier, location, situations):
)


class AboutView(FlaggedTemplateView):
flag_name = "TCCP"
class AboutView(TemplateView):
template_name = "tccp/about.html"
breadcrumb_items = [
{
Expand All @@ -78,8 +76,7 @@ def get_context_data(self, **kwargs):
}


class CardListView(FlaggedViewMixin, ListAPIView):
flag_name = "TCCP"
class CardListView(ListAPIView):
model = CardSurveyData
renderer_classes = [TemplateHTMLRenderer, JSONRenderer]
serializer_class = CardSurveyDataListSerializer
Expand Down Expand Up @@ -193,8 +190,7 @@ def get_purchase_apr_rating_ranges(cls, cards):
return rating_ranges


class CardDetailView(FlaggedViewMixin, RetrieveAPIView):
flag_name = "TCCP"
class CardDetailView(RetrieveAPIView):
model = CardSurveyData
lookup_field = "slug"
renderer_classes = [TemplateHTMLRenderer, JSONRenderer]
Expand Down
Loading