Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change font styling #89

Merged
merged 2 commits into from
Nov 10, 2023
Merged

change font styling #89

merged 2 commits into from
Nov 10, 2023

Conversation

aeddaqqa
Copy link
Contributor

No description provided.

@aeddaqqa aeddaqqa requested a review from Ayagoumi March 15, 2023 10:22
Ayagoumi
Ayagoumi requested changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@Ayagoumi Ayagoumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is incomplete
1 - removal of the non-used fonts files should be included
2 - Adjustment to some word sizes is needed.

src/layout/MainLayout.tsx Outdated Show resolved Hide resolved
src/layout/MainLayout.tsx Outdated Show resolved Hide resolved
src/layout/MainLayout.tsx Outdated Show resolved Hide resolved
@aeddaqqa aeddaqqa force-pushed the fonts-refactor branch 2 times, most recently from 0b923df to ed352b2 Compare March 20, 2023 14:10
@aeddaqqa aeddaqqa requested a review from Ayagoumi March 20, 2023 14:10
Ayagoumi
Ayagoumi previously approved these changes Mar 22, 2023
View reviewed changes
@aeddaqqa aeddaqqa requested a review from Ayagoumi April 4, 2023 11:27
@aeddaqqa aeddaqqa requested a review from Esteban100k June 5, 2023 07:11
@aeddaqqa aeddaqqa requested a review from rafaelkordonias June 19, 2023 12:12
@aeddaqqa aeddaqqa force-pushed the fonts-refactor branch 2 times, most recently from 889dfef to 9f66b0c Compare October 16, 2023 08:10
Ayagoumi
Ayagoumi previously approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@Ayagoumi Ayagoumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aeddaqqa aeddaqqa requested a review from Ayagoumi November 9, 2023 13:38
@aeddaqqa aeddaqqa requested review from mo-c4t and removed request for rafaelkordonias and Esteban100k November 10, 2023 08:49
@aeddaqqa aeddaqqa merged commit 4fc5da4 into suite Nov 10, 2023
4 checks passed
@aeddaqqa aeddaqqa deleted the fonts-refactor branch November 10, 2023 08:53
@Ayagoumi Ayagoumi mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ayagoumi Ayagoumi Ayagoumi approved these changes

@mo-c4t mo-c4t Awaiting requested review from mo-c4t

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeddaqqa @Ayagoumi