Modify the iconColor property of the Banner component to override the color.
#2575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 517b02b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2575 +/- ##
==========================================
- Coverage 81.88% 81.86% -0.03%
==========================================
Files 145 145
Lines 2887 2889 +2
Branches 912 914 +2
==========================================
+ Hits 2364 2365 +1
- Misses 493 494 +1
Partials 30 30 ☔ View full report in Codecov by Sentry. |
Chromatic Report🚀 Congratulations! Your build was successful! |
sungik-choi
reviewed
Dec 20, 2024
Comment on lines
99
to
101
| className={classNames({ | ||
| [styles.Icon]: !iconColor, | ||
| })} |
There was a problem hiding this comment.
Suggested change
| className={classNames({ | |
| [styles.Icon]: !iconColor, | |
| })} | |
| className={classNames( | |
| !iconColor && styles.Icon, | |
| )} |
문자열이 객체 생성 오버헤드가 없어서 성능 이점이 더 있는 거로 알고있어요
sungik-choi
approved these changes
Dec 23, 2024
yangwooseong
force-pushed
the
WEB-6093
branch
from
3f54efa to
517b02b
Compare
sungik-choi
pushed a commit
that referenced
this pull request
Dec 26, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @channel.io/[email protected] ### Patch Changes - Modify the `iconColor` property of the `Banner` component to override the color. ([#2575](#2575)) by @yangwooseong ## [email protected] ### Patch Changes - Updated dependencies - @channel.io/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self Checklist
Related Issue
iconColorofBannercomponent does not override icon color of variant #2574Summary
Details
Breaking change? (Yes/No)
References