Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the iconColor property of the Banner component to override the color. #2575

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Modify the iconColor property of the Banner component to override the color. #2575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c54860d
fix(banner): update icon class handling to conditionally apply styles…
yangwooseong Dec 20, 2024
d5fea8d
chore(changeset): add
yangwooseong Dec 20, 2024
517b02b
refactor(banner): use string instead of object
yangwooseong Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/few-singers-end.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@channel.io/bezier-react': patch
---

Modify the `iconColor` property of the `Banner` component to override the color.
4 changes: 2 additions & 2 deletions packages/bezier-react/src/components/Banner/Banner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,14 +96,14 @@ export const Banner = forwardRef<HTMLDivElement, BannerProps>(function Banner(
<div className={styles.Center}>
{isBezierIcon(icon) ? (
<Icon
className={styles.Icon}
className={classNames(!iconColor && styles.Icon)}
source={icon}
color={iconColor}
size="s"
/>
) : (
<LegacyIcon
className={styles.Icon}
className={classNames(!iconColor && styles.Icon)}
name={icon}
color={iconColor}
size="s"
Expand Down
Loading