fix: add func for git origin #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtsai-czi
merged commit e14bb24
into
CCIE-1804-compute-file-path-tag
3 of 4 checks passed
dtsai-czi
pushed a commit
that referenced
this pull request
Sep 13, 2023
* chore: first change * feat: add filepath of template being executed * tag name change * fix: add func for git origin (#931) * fix: add func for git origin * move test; deadcode * timestamp
dtsai-czi
added a commit
that referenced
this pull request
Sep 18, 2023
…#918) * skeleton for obtaining tags from config * add tags to template * stub stamps * feat: fill in github repository for tags * golden files * CCIE-1806 * deadcode * feat: compute file path tag (#930) * chore: first change * feat: add filepath of template being executed * tag name change * fix: add func for git origin (#931) * fix: add func for git origin * move test; deadcode * timestamp * update golden files * fix git remote url test * stamp cleanup and fix git remote test * remove user from template * update golden files * progress * update golden files * ci update golden files * update actions * token * commit from ci -- updated golden files * fix: populate git related tags with templated terraform (#934) * progress * handle git log errors in script * fix json string formatting * add git data source to template * git helper tags * branch tag * cleanup * add git authors to tags * commit from ci -- updated golden files * git author query formatting * commit from ci -- updated golden files --------- Co-authored-by: Jake Heath <[email protected]> Co-authored-by: Jake Heath <[email protected]> Co-authored-by: jakeyheath <[email protected]> Co-authored-by: dtsai-czi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ccie 1803
Summary
This PR moves the git origin to a template function rather than a struct type that needs to be populated.