Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Schema 4.0.0 tissue_type #701

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Conversation

MillenniumFalconMechanic
Copy link
Collaborator

Reason for Change

  • #6184

Changes

  • Added handling of Schema 4.0.0 tissue_type.

Testing

  • Tested with updated descendant and ancestor fixtures in rdev.
  • Checked cell type fixtures are unchanged.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5cda022) 84.72% compared to head (b2a6069) 84.72%.
Report is 1 commits behind head on main.

❗ Current head b2a6069 differs from pull request most recent head 926b591. Consider uploading reports for the commit 926b591 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #701   +/-   ##
=======================================
  Coverage   84.72%   84.72%           
=======================================
  Files          19       19           
  Lines        1820     1820           
=======================================
  Hits         1542     1542           
  Misses        278      278           
Flag Coverage Δ
unittests 84.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MillenniumFalconMechanic MillenniumFalconMechanic marked this pull request as draft November 30, 2023 21:54
@MillenniumFalconMechanic MillenniumFalconMechanic marked this pull request as ready for review November 30, 2023 22:14
@MillenniumFalconMechanic MillenniumFalconMechanic merged commit 2a6e60e into main Dec 8, 2023
6 checks passed
@MillenniumFalconMechanic MillenniumFalconMechanic deleted the mim/6184-tissue-type branch December 8, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants