Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create standalone gha for updating ontology mappings powering dp fe filters #705

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

nayib-jose-gloria
Copy link
Contributor

@nayib-jose-gloria nayib-jose-gloria commented Dec 12, 2023

Reason for Change

Changes

  • Extracted update ontology mappings job into its own standalone GHA that can be triggered manually, so it can be run outside of migration in case the scripts need to be updated + run + deployed outside a migration cycle

Testing

  • Ran a test from this branch, the GHA ran as expected and kicked off a PR in the data-portal repo with the changes as expected.

Notes for Reviewer

@nayib-jose-gloria nayib-jose-gloria marked this pull request as ready for review December 12, 2023 19:08
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2a6e60e) 84.12% compared to head (cd8283a) 84.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #705      +/-   ##
==========================================
+ Coverage   84.12%   84.17%   +0.05%     
==========================================
  Files          19       19              
  Lines        1871     1871              
==========================================
+ Hits         1574     1575       +1     
+ Misses        297      296       -1     
Flag Coverage Δ
unittests 84.17% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nayib-jose-gloria nayib-jose-gloria requested review from Bento007, 0seastar0 and danieljhegeman and removed request for 0seastar0 December 12, 2023 22:11
@nayib-jose-gloria nayib-jose-gloria merged commit 8b37775 into main Dec 13, 2023
8 checks passed
@nayib-jose-gloria nayib-jose-gloria deleted the nayib/standalone-fe-filter-script-gha branch December 13, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant