-
Notifications
You must be signed in to change notification settings - Fork 423
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Separate correctness and memory tests for ConcurrentMap, LockFreeStac…
…k, and LockFreeQueue (#25392) All of our tests for ConcurrentMap, LockFreeStack, and LockFreeQueue are futures locking down behavior when using `--memLeaks`. This is a bit problematic because: - We weren't locking down the `.bad` behavior so these tests would never catch correctness issues. - For certain nightly jobs we skip futures (such as our nightly M1 Mac / ARM job). - We have infrastructure for tracking known memory leaks but this infrastructure doesn't expect the tests to be futures. To reesolve all this, I've removed the futures and changed these to correctness tests when not using `--memLeaks`. I've also created separate symlinked versions of some of these tests that still run with `--memLeaks`. [Reviewed by @e-kayrakli]
- Loading branch information
Showing
25 changed files
with
66 additions
and
12 deletions.
There are no files selected for viewing
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
#!/bin/bash | ||
|
||
grep -v "\.chpl:.*" < $2 >$2.predifftmp | ||
mv $2.predifftmp $2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
This directory is locking down that we currently have a memory leak for | ||
ConcurrentMap. These tests symlink to equivalent correctness tests and can be | ||
removed once this leak is fixed. |
1 change: 1 addition & 0 deletions
1
test/library/packages/ConcurrentMap/memLeakTests/testAddSet.chpl
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../testAddSet.chpl |
7 changes: 7 additions & 0 deletions
7
test/library/packages/ConcurrentMap/memLeakTests/testAddSet.good
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{1: -1} | ||
|
||
================================================= Memory Leaks ================================================== | ||
Allocated Memory (Bytes) Number Size Total Description Address | ||
================================================================================================================= | ||
================================================================================================================= | ||
|
1 change: 1 addition & 0 deletions
1
test/library/packages/ConcurrentMap/memLeakTests/testClear.chpl
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../testClear.chpl |
7 changes: 7 additions & 0 deletions
7
test/library/packages/ConcurrentMap/memLeakTests/testClear.good
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{} | ||
|
||
================================================= Memory Leaks ================================================== | ||
Allocated Memory (Bytes) Number Size Total Description Address | ||
================================================================================================================= | ||
================================================================================================================= | ||
|
1 change: 1 addition & 0 deletions
1
test/library/packages/ConcurrentMap/memLeakTests/testEquality.chpl
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../testEquality.chpl |
10 changes: 10 additions & 0 deletions
10
test/library/packages/ConcurrentMap/memLeakTests/testEquality.good
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
true | ||
false | ||
false | ||
true | ||
|
||
================================================= Memory Leaks ================================================== | ||
Allocated Memory (Bytes) Number Size Total Description Address | ||
================================================================================================================= | ||
================================================================================================================= | ||
|
1 change: 1 addition & 0 deletions
1
test/library/packages/ConcurrentMap/memLeakTests/testGetRemove.chpl
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../testGetRemove.chpl |
8 changes: 8 additions & 0 deletions
8
test/library/packages/ConcurrentMap/memLeakTests/testGetRemove.good
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
1 | ||
{two: 2} | ||
|
||
================================================= Memory Leaks ================================================== | ||
Allocated Memory (Bytes) Number Size Total Description Address | ||
================================================================================================================= | ||
================================================================================================================= | ||
|
1 change: 1 addition & 0 deletions
1
test/library/packages/ConcurrentMap/memLeakTests/utilFunctions.chpl
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../utilFunctions.chpl |
Empty file.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
#!/bin/bash | ||
|
||
sed -E "s/0x[0-9a-f]*/prediffed/" <$2 >$2.predifftmp | ||
grep prediffed $2.predifftmp | uniq -c >$2 | ||
rm $2.predifftmp | ||
grep -v "\.chpl:.*" < $2 >$2.predifftmp | ||
mv $2.predifftmp $2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
This directory is locking down that we currently have a memory leak for this | ||
module. These tests symlink to equivalent correctness tests and can be removed | ||
once this leak is fixed. |
6 changes: 6 additions & 0 deletions
6
test/library/packages/LockFreeQueue/memLeaks/consistencyCheck.good
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
|
||
================================================= Memory Leaks ================================================== | ||
Allocated Memory (Bytes) Number Size Total Description Address | ||
================================================================================================================= | ||
================================================================================================================= | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
#!/bin/bash | ||
|
||
sed -E "s/0x[0-9a-f]*/prediffed/" <$2 >$2.predifftmp | ||
grep prediffed $2.predifftmp | uniq -c >$2 | ||
rm $2.predifftmp | ||
grep -v "\.chpl:.*" < $2 >$2.predifftmp | ||
mv $2.predifftmp $2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
This directory is locking down that we currently have a memory leak for this | ||
module. These tests symlink to equivalent correctness tests and can be removed | ||
once this leak is fixed. |
6 changes: 6 additions & 0 deletions
6
test/library/packages/LockFreeStack/memLeaks/consistencyCheck.good
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
|
||
================================================= Memory Leaks ================================================== | ||
Allocated Memory (Bytes) Number Size Total Description Address | ||
================================================================================================================= | ||
================================================================================================================= | ||
|