Replacing FILENAME_MAX in compiler-directory

[rchinmay]

Converts char arrays in compiler/ directory to std::string. Resolves #8757 for compiler directory.
@bradcray @cassella @daviditen Please review.
Thanks,
R. Chinmay

[daviditen]

Thanks! Overall I think this looks great for the ~50% that I've gone over so far. I see that the DCO check failed though, I think due to the commit labeled 'Revert "Deleting unnecessary files"'. Can you add the "Signed-off-by: ..." line to that commit?

I ran testing on this PR and came back with the following list of failures. It looks like mostly segfaults.

[Error matching compiler output for compflags/bradc/mungeUserIdents/testmunge-export]
[Error matching compiler output for compflags/bradc/mungeUserIdents/testmunge-extern]
[Error matching compiler output for compflags/bradc/mungeUserIdents/testmunge (compopts: 1)]
[Error matching compiler output for compflags/bradc/mungeUserIdents/testmunge (compopts: 2)]
[Error matching compiler output for compflags/bradc/mungeUserIdents/testmunge (compopts: 1)]
[Error matching compiler output for compflags/bradc/mungeUserIdents/testmunge (compopts: 2)]
[Error matching compiler output for compflags/bradc/nameoutput/localnamesavec]
[Error matching compiler output for compflags/bradc/savecDirExists]
[Error matching compiler output for compflags/codegen/cppLines (compopts: 3)]
[Error matching compiler output for compflags/codegen/cppLines (compopts: 4)]
[Error matching compiler output for compflags/codegen/cppLines (compopts: 3)]
[Error matching compiler output for compflags/codegen/cppLines (compopts: 4)]
[Error matching program output for compflags/diten/savec]
[Error matching compiler output for compflags/shannon/cpplines/cppLines]
[Error matching compiler output for compflags/shannon/cpplines/noCppLines]
[Error matching compiler output for compflags/waynew/saveccurrdir]
[Error matching compiler output for execflags/bradc/gdbddash/declint]
[Error matching compiler output for execflags/bradc/gdbddash/declint2]
[Error matching compiler output for execflags/bradc/gdbddash/gdbSetConfig]
[Error matching compiler output for extern/ferguson/sizeof-extern-type/sizeof-extern-type]
[Error matching compiler output for extern/ferguson/sizeof-extern-type/sizeof-extern-type2]
[Error matching compiler output for functions/ferguson/lineno/no-extra-lineno]
[Error matching compiler output for optimizations/fastFollowers/staticCheck]
[Error matching compiler output for param/bradc/foldUintZeroes]
[Error matching compiler output for parsing/ferguson/no-codegen-formal]
[Error matching compiler output for statements/diten/op_equals_using_C_primitive]
[Error matching compiler output for trivial/bradc/protoast/codegen/test]
[Error matching compiler output for trivial/bradc/protoast/codegen/testEnum]
[Error matching compiler output for trivial/bradc/savecInNonWriteableDir]
[Error matching compiler output for types/range/elliot/anonymousRangeIter]
[Error matching compiler output for users/ferguson/c_line_error/MRA]
[Error matching compiler output for users/ferguson/c_line_error/a]
[Error matching compiler output for users/ferguson/c_line_error/ab]
[Error matching compiler output for users/ferguson/c_line_error/abc]
[Error matching compiler output for users/ferguson/c_line_error/abcd]
[Error matching compiler output for users/ferguson/c_line_error/abcde]
[Error matching compiler output for users/ferguson/c_line_error/abcdefghijklmnopqrstuvwxyz]
[Error matching compiler output for users/ferguson/c_line_error/use_MRA]
[Error matching compiler output for users/ferguson/c_line_error/use_abc]
[Error matching compiler output for users/ferguson/c_line_error/use_abcd]
[Error matching compiler output for users/ferguson/c_line_error/use_abcde]
[Error matching compiler output for users/ferguson/c_line_error/use_abcdefghijklmnopqrstuvwxyz]

[bradcray]

I'd be happy to see this PR proceed, but am closing it due to inactivity.

[riftEmber]

Continuing this work in PR #26357, but not starting from these commits as the big merge onto latest main is more work than is worth it.