-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow arbitrary path lengths in compiler #26357
base: main
Are you sure you want to change the base?
Conversation
fd59f03
to
d6ce41b
Compare
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
d6ce41b
to
47b5b9e
Compare
else | ||
printf("''"); | ||
break; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
definitely outside the scope of this PR, but it would be nice to change 'S' to use std::string too. Maybe open an issue for refactoring the arg parsing code to use more modern C++?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there something you would want to see change about how it functions, besides the internals? I feel "if it ain't broke" about refactoring it, personally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing specific in terms of the API, I mostly am just tired of dealing with very old C-style C++ code, which is true for much of the compiler
I feel "if it ain't broke" about refactoring it, personally.
I kinda tend to agree, but I think there is an aspect of "leave things better than you found it" too. Definitely not advocating you do anything in this regard for this PR.
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Removes usages of
FILENAME_MAX
and other hardcoded buffers for path strings, enabling the use of arbitrarily long file paths.This PR has the same purpose as #17517, but isn't based off of it as the prior PR was too far behind main.
Resolves #26261 and contributes to #8757.
[reviewer info placeholder]
Testing:
--no-compiler-driver
paratest