Skip to content
This repository has been archived by the owner on May 17, 2021. It is now read-only.

Fixing broken SLS behaviour #52

Open
wants to merge 3 commits into
base: redmine-3.0
Choose a base branch
from

Conversation

gregharvey
Copy link

The current redmine-3.0 branch requires signout_url and idp_slo_target_url but the callback path doesn't exist, SLS hasn't been implemented on the Redmine side in this branch. Looks like it was added for 4.x. Consequently, logout cannot succeed but you also cannot make Redmine use local logout (even though the code is actually there to do this).

So this PR does three things:

  1. Stops signout_url and idp_slo_target_url being required for validation (SAML does not require them)
  2. Fixes a little typo in the sign-out method which causes an error
  3. Updates the sample documentation according to what I've discovered the settings should be

Hope this helps! :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant