This repository has been archived by the owner on May 17, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current redmine-3.0 branch requires
signout_url
andidp_slo_target_url
but the callback path doesn't exist, SLS hasn't been implemented on the Redmine side in this branch. Looks like it was added for 4.x. Consequently, logout cannot succeed but you also cannot make Redmine use local logout (even though the code is actually there to do this).So this PR does three things:
signout_url
andidp_slo_target_url
being required for validation (SAML does not require them)Hope this helps! :-)