Skip to content
This repository has been archived by the owner on May 17, 2021. It is now read-only.

Fixing broken SLS behaviour #52

Open
wants to merge 3 commits into
base: redmine-3.0
Choose a base branch
from
Open

Fixing broken SLS behaviour #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e8ed3d
SLS features shouldn't be required, they're not supported in Redmine …
gregharvey Jan 18, 2021
a6bdb9d
Typo in redirect.
gregharvey Jan 18, 2021
7cd8a25
Updating sample for documentation purposes.
gregharvey Jan 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions lib/redmine_omniauth_saml.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,6 @@ def validate_configuration!
:idp_sso_target_url,
:idp_cert_fingerprint,
:name_identifier_format,
:signout_url,
:idp_slo_target_url,
:name_identifier_value,
:attribute_mapping ].each do |k|
raise "Redmine::OmiauthSAML.configure requires that saml.#{k} to be setted" unless saml[k]
Expand Down
2 changes: 1 addition & 1 deletion lib/redmine_omniauth_saml/account_controller_patch.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def sp_logout_request
if not settings[:signout_url]
logger.info "SLO IdP Endpoint not found in settings, executing then a normal logout'"
saml_logout_user
redirect home_path
redirect_to home_path
else

# Since we created a new SAML request, save the transaction_id
Expand Down
11 changes: 6 additions & 5 deletions sample-saml-initializers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
Redmine::OmniAuthSAML::Base.configure do |config|
config.saml = {
:assertion_consumer_service_url => "http://redmine.example.com", # The redmine application hostname
:issuer => "sso_issuer", # The issuer name
:assertion_consumer_service_url => "https://redmine.example.com/auth/saml/callback", # The Redmine callback URL
:issuer => "https://redmine.example.com/auth/saml/metadata", # The entity ID / issuer name
:idp_sso_target_url => "http://sso.desarrollo.unlp.edu.ar/saml2/idp/SSOService.php", # SSO login endpoint
:idp_cert_fingerprint => "certificate fingerprint", # SSO ssl certificate fingerprint
:idp_cert_fingerprint => "certificate fingerprint", # SSO SSL certificate SHA-1 fingerprint
:name_identifier_format => "urn:oasis:names:tc:SAML:2.0:nameid-format:persistent",
:signout_url => "http://sso.example.com/saml2/idp/SingleLogoutService.php?ReturnTo=",
:idp_slo_target_url => "http://sso.example.com/saml2/idp/SingleLogoutService.php",
# SLS is not currently supported in the 3.x branch.
#:signout_url => "http://sso.example.com/saml2/idp/SingleLogoutService.php?ReturnTo=",
#:idp_slo_target_url => "http://sso.example.com/saml2/idp/SingleLogoutService.php",
:name_identifier_value => "mail", # Which redmine field is used as name_identifier_value for SAML logout
:attribute_mapping => {
# How will we map attributes from SSO to redmine attributes
Expand Down