Skip to content

Conversation

@jairad26
Copy link
Contributor

@jairad26 jairad26 commented Jun 21, 2025

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • This PR adds support for the nomic embedding function in the python client
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

Copy link
Contributor Author

jairad26 commented Jun 21, 2025

@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@jairad26 jairad26 force-pushed the jai/query-coll-config branch from 1e6fe2d to a339c38 Compare June 23, 2025 20:38
@jairad26 jairad26 force-pushed the jai/nomic-ef branch 2 times, most recently from 3ce0fcc to be76229 Compare June 24, 2025 17:34
@jairad26 jairad26 force-pushed the jai/query-coll-config branch from a339c38 to 34225f8 Compare June 24, 2025 17:34
@jairad26 jairad26 force-pushed the jai/query-coll-config branch 2 times, most recently from bce5833 to acf3839 Compare June 25, 2025 16:51
@jairad26 jairad26 force-pushed the jai/nomic-ef branch 2 times, most recently from 480ead9 to fe95102 Compare June 25, 2025 21:35
@jairad26 jairad26 force-pushed the jai/query-coll-config branch from acf3839 to feb8131 Compare June 25, 2025 21:35
@jairad26 jairad26 force-pushed the jai/query-coll-config branch 2 times, most recently from 4b1428c to 7eac9c8 Compare June 26, 2025 00:19
@jairad26 jairad26 force-pushed the jai/nomic-ef branch 2 times, most recently from a40c5d4 to 8c0eebb Compare June 30, 2025 23:53
@jairad26 jairad26 force-pushed the jai/query-coll-config branch from 7eac9c8 to bd49feb Compare June 30, 2025 23:53
@jairad26 jairad26 force-pushed the jai/nomic-ef branch 2 times, most recently from 77473be to fd6a8cc Compare July 8, 2025 18:34
@jairad26 jairad26 force-pushed the jai/query-coll-config branch from 36a2766 to 0a6cc75 Compare July 8, 2025 18:34
@jairad26 jairad26 force-pushed the jai/query-coll-config branch from 0a6cc75 to a219bb3 Compare July 11, 2025 21:54
@jairad26 jairad26 force-pushed the jai/query-coll-config branch from a219bb3 to e67eb4f Compare July 25, 2025 19:48
@jairad26 jairad26 force-pushed the jai/query-coll-config branch from e67eb4f to 5f002bb Compare September 9, 2025 19:01
@jairad26 jairad26 force-pushed the jai/query-coll-config branch 2 times, most recently from 5100775 to 5edc33f Compare September 15, 2025 17:58
@jairad26 jairad26 force-pushed the jai/query-coll-config branch from 5edc33f to 341a219 Compare September 16, 2025 00:17
@jairad26 jairad26 force-pushed the jai/nomic-ef branch 2 times, most recently from 06b8369 to 921fdc8 Compare September 16, 2025 07:31
@jairad26 jairad26 force-pushed the jai/query-coll-config branch from 341a219 to 6c083cf Compare September 16, 2025 07:31
@jairad26 jairad26 force-pushed the jai/query-coll-config branch from 6c083cf to 255e7f2 Compare September 16, 2025 15:26
@jairad26 jairad26 changed the base branch from jai/query-coll-config to graphite-base/4911 October 28, 2025 01:04
@jairad26 jairad26 changed the base branch from graphite-base/4911 to main October 28, 2025 01:05
@blacksmith-sh blacksmith-sh bot deleted a comment from jairad26 Oct 28, 2025
@jairad26 jairad26 marked this pull request as ready for review November 6, 2025 14:45
@propel-code-bot
Copy link
Contributor

propel-code-bot bot commented Nov 6, 2025

Introduce NomicEmbeddingFunction and related schema/registry updates

Adds first-class support for generating embeddings via the Nomic platform. The PR introduces a new class NomicEmbeddingFunction, its JSON configuration schema, registers the function in known_embedding_functions, updates the public __all__, and includes the new builtin in unit tests. No existing functionality is removed.

Key Changes

• New file chromadb/utils/embedding_functions/nomic_embedding_function.py implementing text and query embeddings through Nomic’s embed.text() API
• New JSON schema schemas/embedding_functions/nomic.json for config validation
• Registry updates in chromadb/utils/embedding_functions/__init__.py (imports, known_embedding_functions, __all__, builtin list)
• Test suite chromadb/test/ef/test_ef.py now expects NomicEmbeddingFunction to be present

Affected Areas

chromadb/utils/embedding_functions module
schemas/embedding_functions configs
• Embedding function registry and builtin list
• EF unit tests

This summary was automatically generated by @propel-code-bot

@@ -0,0 +1,21 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we validate that we are using these in schema?

Copy link
Collaborator

@HammadB HammadB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments

@jairad26 jairad26 enabled auto-merge (squash) November 7, 2025 03:52
@jairad26 jairad26 merged commit a7c7865 into main Nov 7, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants