Skip to content

Conversation

@jairad26
Copy link
Contributor

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • ...
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor Author

jairad26 commented Jun 24, 2025

@jairad26 jairad26 force-pushed the jai/schema branch 3 times, most recently from b53ecb7 to c190fc0 Compare June 25, 2025 20:50
@jairad26 jairad26 force-pushed the jai/schema branch 2 times, most recently from 7c72258 to 40bcfc3 Compare June 26, 2025 00:19
@jairad26 jairad26 force-pushed the jai/schema branch 3 times, most recently from b396aa3 to ce34f83 Compare June 30, 2025 23:53
@jairad26 jairad26 changed the base branch from jai/nomic-ef to graphite-base/4932 July 8, 2025 18:14
@jairad26 jairad26 force-pushed the graphite-base/4932 branch from 8c0eebb to 77473be Compare July 8, 2025 18:27
@jairad26 jairad26 changed the base branch from graphite-base/4932 to jai/nomic-ef July 8, 2025 18:27
@blacksmith-sh
Copy link
Contributor

blacksmith-sh bot commented Jul 8, 2025

4 Jobs Failed:

PR checks / Python tests / test-rust-single-node-integration (3.9, --ignore-glob 'chromadb/test/property/*' --ignore-glob 'c...

No logs available for this step.

PR checks / Python tests / test-rust-bindings (3.9, --ignore-glob 'chromadb/test/property/*' --ignore-glob 'chromadb/test/st...
Step "Test" from job "Python tests / test-rust-bindings (3.9, --ignore-glob 'chromadb/test/property/*' --ignore-glob 'chromadb/test/st..." is failing. The last 20 log lines are:

[...]
  /opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/httpx/_config.py:51: DeprecationWarning: `verify=<str>` is deprecated. Use `verify=ssl.create_default_context(cafile=...)` or `verify=ssl.create_default_context(capath=...)` instead.
    warnings.warn(message, DeprecationWarning)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
============================= slowest 10 durations =============================
16.17s call     chromadb/test/api/test_limit_offset.py::test_get_limit_offset[rust_sqlite_persistent]
12.63s call     chromadb/test/test_multithreaded.py::test_interleaved_add_query[rust_sqlite_ephemeral]
11.87s call     chromadb/test/api/test_limit_offset.py::test_get_limit_offset[rust_sqlite_ephemeral]
11.58s call     chromadb/test/ef/test_default_ef.py::test_invalid_sha256
10.93s call     chromadb/test/test_cli.py::test_vacuum_errors_if_locked[rust_sqlite_persistent]
10.46s call     chromadb/test/test_multithreaded.py::test_multithreaded_add[rust_sqlite_ephemeral]
8.80s call     chromadb/test/test_multithreaded.py::test_multithreaded_add[rust_sqlite_persistent]
6.93s call     chromadb/test/test_multithreaded.py::test_interleaved_add_query[rust_sqlite_persistent]
5.15s setup    chromadb/test/test_api.py::test_ssl_self_signed[fastapi_ssl]
5.12s call     chromadb/test/test_cli.py::test_app
=========================== short test summary info ============================
FAILED chromadb/test/test_api.py::test_collection_upsert_with_invalid_collection_throws[rust_sqlite_ephemeral] - pyo3_runtime.PanicException: called `Option::unwrap()` on a `None` value
FAILED chromadb/test/test_api.py::test_collection_upsert_with_invalid_collection_throws[rust_sqlite_persistent] - pyo3_runtime.PanicException: called `Option::unwrap()` on a `None` value
= 2 failed, 368 passed, 26 skipped, 1 xfailed, 659 warnings in 148.06s (0:02:28) =
Error: Process completed with exit code 1.
PR checks / all-required-pr-checks-passed
Step "Decide whether the needed jobs succeeded or failed" from job "all-required-pr-checks-passed" is failing. The last 20 log lines are:

[...]
}
EOM
)"
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  GITHUB_REPO_NAME: chroma-core/chroma
  PYTHONPATH: /home/runner/_work/_actions/re-actors/alls-green/release/v1/src
# ❌ Some of the required to succeed jobs failed 😢😢😢

📝 Job statuses:
📝 python-tests → ❌ failure [required to succeed or be skipped]
📝 python-vulnerability-scan → ✓ success [required to succeed or be skipped]
📝 javascript-client-tests → ✓ success [required to succeed or be skipped]
📝 rust-tests → ✓ success [required to succeed or be skipped]
📝 go-tests → ✓ success [required to succeed or be skipped]
📝 lint → ✓ success [required to succeed]
📝 check-helm-version-bump → ⬜ skipped [required to succeed or be skipped]
📝 delete-helm-comment → ✓ success [required to succeed or be skipped]
Error: Process completed with exit code 1.

1 job failed running on non-Blacksmith runners.


Summary: 1 successful workflow, 1 failed workflow

Last updated: 2025-07-09 19:01:00 UTC

@jairad26 jairad26 changed the base branch from jai/nomic-ef to graphite-base/4932 July 9, 2025 18:25
@jairad26 jairad26 force-pushed the graphite-base/4932 branch from e63278b to 72ff620 Compare July 9, 2025 18:25
@jairad26 jairad26 changed the base branch from graphite-base/4932 to main July 9, 2025 18:25
@jairad26 jairad26 closed this Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants