Use latest directory commit timestamp as tag #286
Conversation
Artyop
changed the title
Artyop
force-pushed
the
pr/fix-image-tag-renovate
branch
4 times, most recently
from
38d4a0a
to
e79d616
Compare
Artyop
force-pushed
the
pr/fix-image-tag-renovate
branch
from
e79d616
to
d579daa
Compare
|
Bit of an issue with libc version while creating the images it seems |
|
Can you rebase with main branch to pick up #281 to avoid any surprise? |
Artyop
force-pushed
the
pr/fix-image-tag-renovate
branch
from
6bb158e
to
b665af2
Compare
|
Rebased from main branch, checking for the key issue on the iptables-20.04-image |
iptables-20.04-image might not be used anymore, as we moved to snapshot build for specific iptables version. |
|
#287 is merged, so you might need to rebase again 😅 , good news is no need to check for key issue 🔑 |
well that sounds like a good deal to me! |
This commit change the way of tagging image, from using git-lfs-tree sha256 to using directory's last commit timestamp. It will permit renovate to sort versions and update properly new images, where renovate wasn't able to do so before due to its inability to sort SHAs. Signed-off-by: Antony Reynaud <[email protected]>
Redhat ubi8:8.9-1136 dnf was generating issue to perform remove of gcc and make. Bumping redhat version to ubi8/ubi (from https://catalog.redhat.com/software/base-images) fixed it. Signed-off-by: Antony Reynaud <[email protected]>
Artyop
force-pushed
the
pr/fix-image-tag-renovate
branch
from
b665af2
to
63ec437
Compare
This commit adds the short commit after the timestamp. Will help to know which commit the image version will be coming from. Signed-off-by: Antony Reynaud <[email protected]>
|
@michi-covalent added the short commit right after the timestamp separated with a "-", let me know if it sounds good for you |
Following the pr cilium#286, update of the readme about how the tagging mechanic works Signed-off-by: Antony Reynaud <[email protected]>
Following the pr cilium#286, update of the readme about how the tagging mechanic works Signed-off-by: Antony Reynaud <[email protected]>
Following the pr #286, update of the readme about how the tagging mechanic works Signed-off-by: Antony Reynaud <[email protected]>
This commit change the way of tagging image, from using git-lfs-tree sha256 to using directory's last commit timestamp. It will permit renovate to sort versions and update properly new images, where renovate wasn't able to do so before due to its inability to sort SHAs.
The git log command, when given a specific directory in parameter, retrieve the last commit were changes were made in said directory. This means that we can ensure different image versions same as used to be with git-tree.
Renovate can sort versions from left to right, using a timestamp as a tag value allows it to retrieve the latest version deployed with ease.
Fixes #285