Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get git history to make tagging mechanic work properly #296

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

Artyop
Copy link
Contributor

@Artyop Artyop commented Aug 9, 2024

actions/checkout by default retrieve only the last commit of the repository. If we want the tagging mechanic to work properly we need the full history so we can know the actual real last commit of the image directory when tagging

actions/checkout by default retrieve only the last commit of the repository.
If we want the tagging mechanic to work properly we need the full history so we
can know the actual real last commit of the image directory when tagging

Signed-off-by: Antony Reynaud <[email protected]>
@Artyop Artyop marked this pull request as ready for review September 4, 2024 09:53
@Artyop Artyop requested review from a team as code owners September 4, 2024 09:53
@Artyop Artyop requested review from aanm and nebril September 4, 2024 09:53
@Artyop
Copy link
Contributor Author

Artyop commented Sep 5, 2024

@aanm would you be kind and merge it too? I don't have the rights unfortunately

@nebril nebril merged commit e3a8a75 into cilium:master Sep 6, 2024
2 checks passed
@Artyop
Copy link
Contributor Author

Artyop commented Sep 6, 2024

thanks @nebril 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants