Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get git history to make tagging mechanic work properly #296

Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix: get git history to make tagging mechanic work properly #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/images.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ jobs:
echo "push=${PUSH}" >> $GITHUB_OUTPUT

- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
with:
fetch-depth: 0
- uses: docker://quay.io/cilium/image-maker:e55375ca5ccaea76dc15a0666d4f57ccd9ab89de
name: Register binfmt from multi-platform builds
with:
Expand Down
2 changes: 1 addition & 1 deletion scripts/make-image-tag.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ root_dir="$(git rev-parse --show-toplevel)"
cd "${root_dir}"

if [ "$#" -eq 1 ] ; then
# if one argument was given, assume it's a directory and obtain a tree hash
# if one argument was given, assume it's a directory and retrieve its last commit to generate a tag
image_dir="${1}"
if ! [ -d "${image_dir}" ] ; then
echo "${image_dir} is not a directory (path is relative to git root)"
Expand Down