Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change picOrderCnt to 2 #3752

Merged
merged 7 commits into from
Jul 3, 2024
Merged

Change picOrderCnt to 2 #3752

merged 7 commits into from
Jul 3, 2024

Conversation

fippo
Copy link
Contributor

@fippo fippo commented May 10, 2024

changes the picOrderCnt field to 2 (which means the output order
is the same as the decode order) which is more suited to realtime
usage and allows the decoder to immediately decode a frame without
waiting for out-of-order frames. This reduces the decoding latency
on Qualcomm hardware decoders which do not honor the VUI parameter
max_num_reorder_frames

@Hawthorne001
Copy link

approve

@fippo
Copy link
Contributor Author

fippo commented May 14, 2024

Looks like the ASAN test is running some tests that are not run by the normal test suite, see the commit titled "bump asan hashes"? And fixing the hashes for ASAN breaks them for the normal tests locally (on Linux)?! Reverting and make clean fixed this so this seems to be a minor issue with the test build deps; as long as the CI catches it all is well.

@BenzhengZhang
Copy link
Collaborator

@fippo Could you pls submit a new PR and I will start CI.

fippo added 7 commits July 1, 2024 07:35
changes the picOrderCnt field to 2 (which means the output order
is the same as the decode order) which is more suited to realtime
usage and allows the decoder to immediately decode a frame without
waiting for out-of-order frames. This reduces the decoding latency
on Qualcomm hardware decoders which do not honor the VUI parameter
  max_num_reorder_frames
This reverts commit 7aa8b3d.
@fippo
Copy link
Contributor Author

fippo commented Jul 1, 2024

@BenzhengZhang now that I have had a change merged github considers me to be a friendly person so starts the CI automatically! Builds passed 🎉, would you like me to squash all the hash updates?

@BenzhengZhang BenzhengZhang merged commit 478e5ab into cisco:master Jul 3, 2024
8 checks passed
@fippo fippo deleted the picordercnt branch July 3, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants