-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default license key to manual and automated tests. #996
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add two tests (one per config type - automated and manual) that verify if we pass the window?CKEDITOR_...
string to the webpack.DefinePlugin
constructor?
Similar to:
ckeditor5-dev/packages/ckeditor5-dev-tests/tests/utils/automated-tests/getwebpackconfig.js
Lines 126 to 137 in e0775b7
it( 'should return webpack configuration with loaded identity file', () => { | |
stubs.getDefinitionsFromFile.returns( { LICENSE_KEY: 'secret' } ); | |
const webpackConfig = getWebpackConfigForAutomatedTests( { | |
identityFile: 'path/to/secrets.js' | |
} ); | |
const plugin = webpackConfig.plugins[ 0 ]; | |
expect( stubs.getDefinitionsFromFile.firstCall.args[ 0 ] ).to.equal( 'path/to/secrets.js' ); | |
expect( plugin.definitions.LICENSE_KEY ).to.equal( 'secret' ); | |
} ); |
It should help us when we switch tooling used in the environment to ensure that this variable is injected properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
Suggested merge commit message (convention)
Internal: Adds default license key to manual and automated tests.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.