Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default license key to manual and automated tests. #996

Merged
merged 12 commits into from
Sep 6, 2024

Conversation

mmotyczynska
Copy link
Contributor

Suggested merge commit message (convention)

Internal: Adds default license key to manual and automated tests.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@coveralls
Copy link

coveralls commented Sep 3, 2024

Coverage Status

coverage: 91.042% (+0.001%) from 91.041%
when pulling def11e0 on ck/epic/melman
into f2b8130 on master.

Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add two tests (one per config type - automated and manual) that verify if we pass the window?CKEDITOR_... string to the webpack.DefinePlugin constructor?

Similar to:

it( 'should return webpack configuration with loaded identity file', () => {
stubs.getDefinitionsFromFile.returns( { LICENSE_KEY: 'secret' } );
const webpackConfig = getWebpackConfigForAutomatedTests( {
identityFile: 'path/to/secrets.js'
} );
const plugin = webpackConfig.plugins[ 0 ];
expect( stubs.getDefinitionsFromFile.firstCall.args[ 0 ] ).to.equal( 'path/to/secrets.js' );
expect( plugin.definitions.LICENSE_KEY ).to.equal( 'secret' );
} );

It should help us when we switch tooling used in the environment to ensure that this variable is injected properly.

Copy link
Contributor

@martnpaneq martnpaneq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@mmotyczynska mmotyczynska merged commit 6252adf into master Sep 6, 2024
6 checks passed
@mmotyczynska mmotyczynska deleted the ck/epic/melman branch September 6, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants