Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default license key to manual and automated tests. #996

Merged
merged 12 commits into from
Sep 6, 2024
Merged

Add default license key to manual and automated tests. #996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f9fd402
Add testing env global variable by default to manual and automated te…
mmotyczynska May 27, 2024
62ab5d6
Pass 'GPL' as global license key in tests (automated & manual).
mmotyczynska Jun 6, 2024
b84fd59
Merge remote-tracking branch 'origin/master' into ck/epic/melman
mmotyczynska Jun 28, 2024
ce92bfc
Merge remote-tracking branch 'origin/master' into ck/epic/melman
mmotyczynska Jul 25, 2024
028f5c2
Merge remote-tracking branch 'origin/master' into ck/epic/melman
mmotyczynska Aug 7, 2024
96ec754
Merge remote-tracking branch 'origin/master' into ck/epic/melman
mmotyczynska Sep 3, 2024
0092f82
Revert "Pass 'GPL' as global license key in tests (automated & manual)."
mmotyczynska Sep 3, 2024
9bd4f30
Revert "Add testing env global variable by default to manual and auto…
mmotyczynska Sep 3, 2024
e0775b7
Add global license key to manual and automated tests.
mmotyczynska Sep 3, 2024
aa3c324
Revert "Add global license key to manual and automated tests."
mmotyczynska Sep 4, 2024
0b94cd2
Revert "Revert "Add testing env global variable by default to manual …
mmotyczynska Sep 4, 2024
def11e0
Revert "Revert "Pass 'GPL' as global license key in tests (automated …
mmotyczynska Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/ckeditor5-dev-tests/lib/tasks/runautomatedtests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,9 @@ function createEntryFile( globPatterns, production ) {
throw new Error( 'Not found files to tests. Specified patterns are invalid.' );
}

// Set global license key in the `before` hook.
allFiles.unshift( path.join( __dirname, '..', 'utils', 'automated-tests', 'licensekeybefore.js' ).replace( /\\/g, '/' ) );

// Inject the leak detector root hooks. Need to be split into two parts due to #598.
allFiles.splice( 0, 0, path.join( __dirname, '..', 'utils', 'automated-tests', 'leaksdetectorbefore.js' ).replace( /\\/g, '/' ) );
allFiles.push( path.join( __dirname, '..', 'utils', 'automated-tests', 'leaksdetectorafter.js' ).replace( /\\/g, '/' ) );
Expand Down
11 changes: 11 additions & 0 deletions packages/ckeditor5-dev-tests/lib/utils/automated-tests/licensekeybefore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
/**
* @license Copyright (c) 2003-2024, CKSource Holding sp. z o.o. All rights reserved.
* For licensing, see LICENSE.md.
*/

/* global window */

// eslint-disable-next-line mocha/no-top-level-hooks
before( function() {
window.CKEDITOR_GLOBAL_LICENSE_KEY = 'GPL';
} );
1 change: 1 addition & 0 deletions packages/ckeditor5-dev-tests/lib/utils/manual-tests/compilehtmlfiles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ function compileHtmlFile( buildDir, options ) {
'<script src="/assets/websocket.js"></script>' +
'<script src="/assets/inspector.js"></script>' +
'<script src="/assets/attachinspector.js"></script>' +
'<script src="/assets/globallicensekey.js"></script>' +
`${ languagesToLoad.map( language => {
return `<script src="/translations/${ language }.js"></script>`;
} ).join( '' ) }` +
Expand Down
1 change: 1 addition & 0 deletions packages/ckeditor5-dev-tests/lib/utils/manual-tests/copyassets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ const assets = [
path.join( __dirname, 'togglesidebar.js' ),
path.join( __dirname, 'attachinspector.js' ),
path.join( __dirname, 'websocket.js' ),
path.join( __dirname, 'globallicensekey.js' ),
require.resolve( '@ckeditor/ckeditor5-inspector' )
];

Expand Down
8 changes: 8 additions & 0 deletions packages/ckeditor5-dev-tests/lib/utils/manual-tests/globallicensekey.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
/**
* @license Copyright (c) 2003-2024, CKSource Holding sp. z o.o. All rights reserved.
* For licensing, see LICENSE.md.
*/

/* global window */

window.CKEDITOR_GLOBAL_LICENSE_KEY = 'GPL';
5 changes: 5 additions & 0 deletions packages/ckeditor5-dev-tests/tests/utils/manual-tests/compilehtmlfiles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ describe( 'compileHtmlFiles', () => {
'<script src="/assets/websocket.js"></script>' +
'<script src="/assets/inspector.js"></script>' +
'<script src="/assets/attachinspector.js"></script>' +
'<script src="/assets/globallicensekey.js"></script>' +
'<script src="/path/to/manual/file.js"></script>' +
'</body>'
].join( '\n' )
Expand Down Expand Up @@ -207,6 +208,7 @@ describe( 'compileHtmlFiles', () => {
'<script src="/assets/websocket.js"></script>' +
'<script src="/assets/inspector.js"></script>' +
'<script src="/assets/attachinspector.js"></script>' +
'<script src="/assets/globallicensekey.js"></script>' +
'<script src="/translations/en.js"></script>' +
'<script src="/translations/pl.js"></script>' +
'<script src="/translations/ar.js"></script>' +
Expand Down Expand Up @@ -251,6 +253,7 @@ describe( 'compileHtmlFiles', () => {
'<script src="/assets/websocket.js"></script>' +
'<script src="/assets/inspector.js"></script>' +
'<script src="/assets/attachinspector.js"></script>' +
'<script src="/assets/globallicensekey.js"></script>' +
'<script src="/path/to/manual/file.abc.js"></script>' +
'</body>'
].join( '\n' )
Expand Down Expand Up @@ -324,6 +327,7 @@ describe( 'compileHtmlFiles', () => {
'<script src="/assets/websocket.js"></script>' +
'<script src="/assets/inspector.js"></script>' +
'<script src="/assets/attachinspector.js"></script>' +
'<script src="/assets/globallicensekey.js"></script>' +
'<script src="/path/to/manual/file.js"></script>' +
'</body>'
].join( '\n' )
Expand Down Expand Up @@ -404,6 +408,7 @@ describe( 'compileHtmlFiles', () => {
'<script src="/assets/websocket.js"></script>' +
'<script src="/assets/inspector.js"></script>' +
'<script src="/assets/attachinspector.js"></script>' +
'<script src="/assets/globallicensekey.js"></script>' +
'<script src="/path/to/manual/file.js"></script>' +
'</body>'
].join( '\n' )
Expand Down