Version 2.0.0 #39
Version 2.0.0 #39
Conversation
Remove white spaces and line breaks from changes text
Re-use newInstance constuctor.
ckChangeLog-core/build.gradle
Outdated
| @@ -7,10 +7,14 @@ android { | |||
| defaultConfig { | |||
| versionName "1.2.2" | |||
|
|
|||
| minSdkVersion 4 | |||
| minSdkVersion 14 | |||
There was a problem hiding this comment.
Is there a technical reason for raising the minSdkVersion for ckChangeLog-core and ckChangeLog-dialog here? I changed it back to 4 and compiled locally and could run my app without an issue.
| throw new IllegalStateException(e); | ||
| } | ||
|
|
||
| return result; |
There was a problem hiding this comment.
Return a copy here to avoid that the caller mutates the state of the list.
There was a problem hiding this comment.
@cketti Not sure if GitHub send you a notification for my review. Please confirm.
There was a problem hiding this comment.
It shouldn't be necessary to create a defensive copy, since the ownership of the list basically goes to the caller (XmlParser instances don't outlive the parsing process; see XmlParser.parse(…)).
But I guess we could wrap the list using Collections.unmodifiableList() to avoid callers depending on a modifiable list.
|
@cketti Any timeline for the release of v2? |
This is mostly due to AAPT(2) optimizing files in res/xml/ and there's no guarantee this won't break our files. Sadly, there has been at least one bug that affected ckChangeLog. See issue #48.
Showing a dialog at app start is a very obtrusive way of showing the change log. Also using a WebView isn't great. The intended message of adding "legacy" is: Stay away from this artifact when writing new code.
|
I'm hoping to release 2.0.0 in the next couple of days. Last chance to provide feedback. |
|
Great! I am trying to look into the changes within this week and will provide feedback. |
First review
|
|
Hi! This should be merged. I am trying to compile with build tools version 28.0.3 but it's failing. |
Feel free to provide feedback.
Fixes #34
Fixes #42
Fixes #48