Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

External chart dependencies #12

Closed
wants to merge 3 commits into from
Closed

External chart dependencies #12

wants to merge 3 commits into from

Conversation

valeriano-manassero
Copy link
Contributor

I see usually a good practice is to use helm dependencies when possible to have a smoother maintenance duties.

This PR is still WIP so I started with Redis substituting the custom deployment with a new one using official Bitnami chart.
In this way it's easier to maintain and we still have full control on version/custom configs on Redis.

If you like this implementation I can do the same for Elasticsearch and MongoDB to this PR before requesting a review.

@jkhenning
Copy link
Member

Hi @valeriano-manassero ,

I assume the removal of the persistent storage section is due to the fact that this will be handled by the specific Redis, MongoDB and Elastic charts?

@valeriano-manassero
Copy link
Contributor Author

valeriano-manassero commented Dec 21, 2020

I assume the removal of the persistent storage section is due to the fact that this will be handled by the specific Redis, MongoDB and Elastic charts?

Exactly. Atm I just implemented Redis but you can see the section redis: in values.yaml that is totally configurable with these values https://github.com/bitnami/charts/blob/master/bitnami/redis/values.yaml

So you can configure also persistent storage or clustering configurations of persist itself without impacting Trains config.

I can try to do same for Elastic and MongoDB so you will have to maintain only Trains chart using these apps as dependency

@jkhenning
Copy link
Member

I can try to do same for Elastic and MongoDB so you will have to maintain only Trains chart using these apps as dependency

That would be great! Thanks 😄

@valeriano-manassero
Copy link
Contributor Author

MongoDB added to the refactoring process. Still WIP since Elasticsearch needs to be moved too.

@valeriano-manassero valeriano-manassero changed the title [WIP] external dependencies External chart dependencies Dec 23, 2020
@valeriano-manassero
Copy link
Contributor Author

Finally WIP is over.

I squashed some commits to get a clear history.
Redis, MongoDB and Elasticsearch are now managed as external dependencies maintaining full control using values.

Let me know if it works for you.

@valeriano-manassero
Copy link
Contributor Author

Closing so I will propose changes on ClearML chart.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants