-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary WebSocket API: Brotli-compress all outgoing messages #1026
Conversation
Co-authored-by: joshua-spacetime <[email protected]> Signed-off-by: Phoebe Goldman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment about reducing the buffer size to 32KB, but otherwise is good.
C# client counterpart for clockworklabs/SpacetimeDB#1026.
Bot test resultsConclusion: 🤷 🧐 Note:
|
Results posted in other channels have shown this to significantly improve (though not eliminate) network latency for large |
C# client counterpart for clockworklabs/SpacetimeDB#1026.
* Binary WebSocket API: Brotli-compress all outgoing messages * Decrease buffer size; comment on future work Co-authored-by: joshua-spacetime <[email protected]> Signed-off-by: Phoebe Goldman <[email protected]> * Note experimental compression ratio --------- Signed-off-by: Phoebe Goldman <[email protected]> Co-authored-by: joshua-spacetime <[email protected]>
Description of Changes
Simpler solution to #1022 , compared to #1021 or #1023 .
With this commit, all outgoing messages using the binary protocol (i.e. Protobuf) are Brotli-compressed at level 1 (fastest, least compression).
API and ABI breaking changes
Unsure which breakage label is correct. Breaks the binary WebSocket API, and so will require changes to:
If this is an API or ABI breaking change, please apply the
corresponding GitHub label.
Expected complexity level and risk
3 - breaking the WebSocket API is scary.
How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!