-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
brotli-decompress received binary websocket messages #41
Conversation
Let's switch to brotli-dec-wasm instead, should be faster & smaller (1.5 MB for brotli.js vs 350KB for brotli-dec-wasm). |
That way we'll be able to get rid of extra Buffer dependency too, which really shouldn't be necessary on the Web. |
@RReverser 's version would have been better, but it turns out that making it work across different platforms (incl. the test platform) is a pain. We'll merge this now, and make improvements later. |
I was also wrong about 1.5MB - because you imported But yeah we'll revisit in future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"LGTM"; this doesn't seem to have much surface area besides obviously-needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, LGTM.
Description of Changes
Uses brotli.js to decompress incoming binary messages before Protobuf deserializing.
API
If the API is breaking, please state below what will break
Requires SpacetimeDB PRs