Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

c# client SDK (DbConnection + SDK Callbacks) #131

Merged
merged 14 commits into from
Oct 1, 2024
Merged

c# client SDK (DbConnection + SDK Callbacks) #131

merged 14 commits into from
Oct 1, 2024

Conversation

lcodes
Copy link
Contributor

@lcodes lcodes commented Sep 12, 2024

Implementation of the db connection proposal for C#

@lcodes lcodes mentioned this pull request Sep 12, 2024
Merged
@lcodes lcodes force-pushed the jeremie/client-sdk-api branch from 0afae7b to 8bd8055 Compare September 12, 2024 15:49
@RReverser
Copy link
Contributor

You might want to rebase & retarget this against the staging branch that has some of the latest changes not yet on master.

RReverser
RReverser reviewed Sep 12, 2024
View reviewed changes
src/Stubs.cs Outdated Show resolved Hide resolved
RReverser
RReverser reviewed Sep 16, 2024
View reviewed changes
src/Stubs.cs Outdated Show resolved Hide resolved
RReverser
RReverser reviewed Sep 16, 2024
View reviewed changes
src/SpacetimeDBClient.cs Outdated Show resolved Hide resolved
@RReverser
Copy link
Contributor

RReverser commented Sep 16, 2024 •
edited
Loading

You might want to rebase & retarget this against the staging branch that has some of the latest changes not yet on master.

@lcodes Also in case you missed this one above. This should exclude some unrelated changes from your PR (also we just shouldn't merge into master).

@lcodes lcodes force-pushed the jeremie/client-sdk-api branch from 8468e56 to 37cabae Compare September 19, 2024 17:12
@lcodes lcodes changed the base branch from master to staging September 19, 2024 17:13
RReverser
RReverser reviewed Sep 23, 2024
View reviewed changes
src/Stubs.cs Outdated Show resolved Hide resolved
RReverser
RReverser reviewed Sep 24, 2024
View reviewed changes
src/Stubs.cs Outdated Show resolved Hide resolved
@RReverser RReverser force-pushed the jeremie/client-sdk-api branch from 28a1b19 to fcdd3dd Compare September 25, 2024 15:54
@lcodes lcodes changed the title c# client SDK c# client SDK (DbConnection) Sep 25, 2024
@lcodes lcodes force-pushed the jeremie/client-sdk-api branch 2 times, most recently from 0141e83 to 7e57315 Compare September 29, 2024 05:25
@lcodes lcodes force-pushed the jeremie/client-sdk-api branch from 56f9986 to 70d4a92 Compare September 29, 2024 05:36
@lcodes lcodes force-pushed the jeremie/client-sdk-api branch from e47a845 to 5a8384e Compare September 29, 2024 05:41
@lcodes lcodes changed the title c# client SDK (DbConnection) c# client SDK (DbConnection + SDK Callbacks) Sep 29, 2024
RReverser
RReverser reviewed Sep 30, 2024
View reviewed changes
src/SpacetimeDBClient.cs Outdated Show resolved Hide resolved
@RReverser
Copy link
Contributor

@lcodes Can unhandledReducerError, onEvent and so on be made internal as well now? Ideally hide all the APIs that are now covered elsewhere.

@RReverser RReverser mentioned this pull request Sep 30, 2024
Merged
1 task
@lcodes lcodes merged commit 7bef448 into staging Oct 1, 2024
2 checks passed
@lcodes lcodes deleted the jeremie/client-sdk-api branch October 1, 2024 01:06
bfops added a commit that referenced this pull request Oct 4, 2024
@bfops @Centril
@lcodes @RReverser @SteveBoytsun @jdetter
Release v0.12.0 (#159)
7e1cf1d 
## Description of Changes
Release these changes:
```
2783385 0.12.0 DLLs (again) (#161)
7046408 Update to tests/examples follow codegen changes (#160)
a7c720f Use SpacetimeDBNetworkManager everywhere (#157)
8916c18 Upgrade SDK Version to 0.12 (#156)
b79d90c Fix UnityNetworkManager (#141)
cff42fb Accept multiple queries in Subscribe (#153)
8f9614d Update DLLs for 0.12.0 (#152)
62a092e Jeremie/remove break (#154)
ce76890 Try to catch flaky bugs (#150)
8ce9b7b Remove obsolete tools folder (#149)
19e8979 Fix `gen-client-api` scripts for new CLI API (#151)
f04e2fd Add script to generate `nuget.config` (#115)
f9c71c0 Don't actually try to connect to network in tests (#144)
00d2741 Reduce public API surface further (#145)
2bed3c3 Tighten package sources in C# smoketests (#133)
63e6f79 Fix UnityDebugLogger implementation (#143)
8df6d15 Implement websocket changes atop C# sdk changes (#136)
95b9d17 Hide more APIs (#140)
2aae961 Add DbConnection argument to OnConnect (#138)
0981b89 Merge table cache into table handle (#139)
f8ddab7 Subscription API (#137)
7bef448 c# client SDK (DbConnection + SDK Callbacks) (#131)
65c97ad Logging API (#132)
7941798 Copy files from old repo (#127)
9904a02 Nix `Primitives.cs` - types now defined in main repo (#120)
5e612f3 Update DEVELOP.md to reflect new codegen (#119)
ae7c531 Restore `dotnet pack` functionality (#118)
9481380 Don't use BuiltinType.I/U128, use AlgebraicType.I/U128 (#116)
```
## API
Almost certainly a breaking change


## Requires SpacetimeDB PRs
Requires version 0.12.0 in SpacetimeDB

---------

Co-authored-by: Mazdak Farrokhzad <[email protected]>
Co-authored-by: Zeke Foppa <[email protected]>
Co-authored-by: Jeremie Pelletier <[email protected]>
Co-authored-by: Ingvar Stepanyan <[email protected]>
Co-authored-by: SteveGibson <[email protected]>
Co-authored-by: Steve Boytsun <[email protected]>
Co-authored-by: John Detter <[email protected]>
Co-authored-by: John Detter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RReverser RReverser RReverser approved these changes

@gefjon gefjon gefjon left review comments

Assignees
No one assigned
Labels
api-break
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lcodes @RReverser @gefjon