Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More permissive orchard.info parsing of stacktrace output #320

Merged
merged 3 commits into from
Mar 6, 2025

Conversation

alexander-yakushev
Copy link
Member

@alexander-yakushev alexander-yakushev commented Mar 5, 2025

This is part 1 of simplifying Haystack usecases. I think this PR is self-sufficient enough to be reviewed individually.

The proposed changes relax the requirements for Java classes/members and Clojure vars to be inferred using orchard.info/info. Now it can recognize all printed stacktrace formats. The examples are in the tests. This influences:

  • Better jump to definition (can jump directly from the REPL output without no extra prep)
  • Better cider-doc support
  • Even eldoc (this looks a bit funny, consider yourself if we should restrict this somehow).
image image image image image image
  • You've added tests to cover your change(s)
  • You've updated the changelog

@alexander-yakushev alexander-yakushev force-pushed the permissive-info-from-stacktraces branch 4 times, most recently from dbb9fad to 1872831 Compare March 5, 2025 21:33
@alexander-yakushev alexander-yakushev force-pushed the permissive-info-from-stacktraces branch from 1872831 to 59e3340 Compare March 5, 2025 21:38
Copy link
Member

@bbatsov bbatsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed changes look very good to me!

I'd say the eldoc in the stacktraces is a feature.

@alexander-yakushev alexander-yakushev merged commit 9fb3df8 into master Mar 6, 2025
20 checks passed
@alexander-yakushev alexander-yakushev deleted the permissive-info-from-stacktraces branch March 6, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants