-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stacktrace] Repatriate stacktrace analyzer from Haystack #322
Conversation
f60e651
to
0920bb8
Compare
b06d34f
to
9967858
Compare
@@ -0,0 +1,318 @@ | |||
(ns orchard.stacktrace | |||
"Cause and stacktrace analysis for exceptions" | |||
{:added "0.31" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can expand this a bit, to be more in line with the level of high-level descriptions that most other namespaces have.
test/orchard/stacktrace_test.clj
Outdated
(is (not (:data (first causes2)))))) | ||
|
||
(deftest compilation-errors-test | ||
(is (match? #"Syntax error compiling at \(.*orchard/stacktrace_test\.clj:" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to have all assertions in testing
, so that the output is a bit more descriptive, but it's not a big deal.
Looks pretty good to me overall. |
3580b84
to
39f5083
Compare
39f5083
to
0189ce4
Compare
Done. |
Great work! |
This PR brings
haystack.analyzer
back home to Orchard. This is not an exact copy; I also did a lot of work in rewriting it to make leaner and faster.The next step will be to switch cider-nrepl to this. I suspect that as I start working on that, I'll have to make some fixes here too; but I think it's fine to review and merge the current state first.