Python 3.13 support #158
Merged
Python 3.13 support #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 2 is no longer supported in Ubuntu docker image
movermeyer
force-pushed
the
movermeyer/python_313_support
branch
3 times, most recently
from
34a9dff to
4ae02e1
Compare
movermeyer
force-pushed
the
movermeyer/python_313_support
branch
from
4ae02e1 to
08f4a50
Compare
movermeyer
commented
Nov 10, 2024
| @@ -27,7 +31,7 @@ jobs: | |||
| docker: | |||
| - image: circleci/python:3.4 | |||
|
|
|||
| test: | |||
| test_old_pythons: | |||
There was a problem hiding this comment.
These versions of Python don't have access to setuptools==71.1.0, so were implicitly pinned at older versions already.
squeaky-pl
reviewed
Dec 3, 2024
squeaky-pl
approved these changes
Dec 3, 2024
|
You maybe would want to remove some old Python version classifiers from setup.py as well. |
@squeaky-pl We still support all those versions though (at least, we've kept all the edge-case handling for them in the code). #157 is the ticket for capturing the drag of old versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
#155
Adding support for Python 3.13
What approach did you choose and why?
I added 3.13 everywhere.
I had to adjust some calls to
execas a result of thelocalschanges that happened in 3.13.Otherwise the imports wouldn't result in changes to the
globals, so subsequent calls wouldn't see the libraries as imported.I also had to pin the version of
setuptoolsto an old version, since they dropped support for being used as a test runner in v72 (#147).What should reviewers focus on?
🤷, once this is merged, I'll rebase #154, and we should be able to get 2.3.2 released 🤞.
The impact of these changes
We'll have Python 3.13 in our tests and our builds.