Bugfix: make sure AMQPSource reconnects #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spuun
requested review from
carlhoerberg,
kickster97,
snichme and
viktorerlingsson
as code owners
snichme
approved these changes
Aug 16, 2024
spuun
force-pushed
the
shovels-destination-reconnects
branch
from
cfa1dbb
to
a24a97c
Compare
spuun
changed the title
spuun
added a commit
that referenced
this pull request
Aug 27, 2024
spuun
added a commit
that referenced
this pull request
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
The shovel Runner will restart Source and Destionation when an exception occurs in any of them. The Source was however not restarted because it was in a "started" state because it didn't change state on all exceptions because exception was rescued in the wrong place.
This PR will rescue all exceptions and stop the source before re-raising the exception to the Runner.
HOW can this pull request be tested?
Specs