Create and use snapshot by default in all wd_py_tests
#3415
+116
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
force-pushed
the
hoodmane/wd-py-test-save-snapshot-variant
branch
from
d9b7619 to
bfddf71
Compare
dom96
approved these changes
Jan 28, 2025
| @@ -21,6 +21,8 @@ py_wd_test("env-param") | |||
| py_wd_test( | |||
| "asgi", | |||
| skip_python_flags = ["0.27.1"], | |||
| # TODO: investigate failure! | |||
| snapshot_variant = False, | |||
There was a problem hiding this comment.
Just to make it a bit clearer:
Suggested change
| snapshot_variant = False, | |
| snapshot_generating_variant = False, |
danlapid
requested changes
Jan 28, 2025
1 task
|
You all probably know this already, but just to make sure we're on the same page: we already have test coverage for this in EW. The fastest way forward would be to just add the vendored worker sample in there. Of course, creating test coverage for this in workerd is still useful and we should do it (assuming the effort required isn't too massive). |
hoodmane
force-pushed
the
hoodmane/wd-py-test-save-snapshot-variant
branch
from
bfddf71 to
ce54902
Compare
|
The generated output of |
hoodmane
force-pushed
the
hoodmane/wd-py-test-save-snapshot-variant
branch
3 times, most recently
from
efc7305 to
f2be084
Compare
Having these unindented lines inside of a conditional block makes the flow control hard to read
hoodmane
force-pushed
the
hoodmane/wd-py-test-save-snapshot-variant
branch
from
f2be084 to
a4781a4
Compare
hoodmane
changed the title
wd_py_testswd_py_tests
hoodmane
force-pushed
the
hoodmane/wd-py-test-save-snapshot-variant
branch
from
a4781a4 to
f6b4c2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't as good as having actual validator coverage but it should help catch a lot of the problems we're having at validation time.
On top of #3476.