Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor copy change in rollback #6123

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

WalshyDev
Copy link
Member

@WalshyDev WalshyDev commented Jun 21, 2024

What this PR solves / how to test

Addressing product copy changes

(FYI: This PR is good to merge if a release is going out - just keeping open if product want further changes)

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because: minor copy changes, no functional changes
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: just copy changes

Copy link

changeset-bot bot commented Jun 21, 2024

⚠️ No Changeset found

Latest commit: e4a79b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -119,7 +119,7 @@ describe("rollback", () => {
mockPostDeployment();

mockPrompt({
text: "Please provide a message for this rollback (120 characters max, optional)?",
text: "Please provide an optional message for this rollback (120 characters max)?",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this failed locally since we changed this messaging during review @CarmenPopoviciu but CI was passing?
Is CI not running this test for some reason or any idea why this passed?

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9619498719/npm-package-wrangler-6123

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6123/npm-package-wrangler-6123

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9619498719/npm-package-wrangler-6123 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9619498719/npm-package-create-cloudflare-6123 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9619498719/npm-package-cloudflare-kv-asset-handler-6123
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9619498719/npm-package-miniflare-6123
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9619498719/npm-package-cloudflare-pages-shared-6123
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9619498719/npm-package-cloudflare-vitest-pool-workers-6123

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240610.1
workerd 1.20240610.1 1.20240610.1
workerd --version 1.20240610.1 2024-06-10

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu CarmenPopoviciu added the e2e Run e2e tests on a PR label Jun 22, 2024
@WalshyDev WalshyDev marked this pull request as ready for review June 24, 2024 21:03
@WalshyDev WalshyDev requested a review from a team as a code owner June 24, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

None yet

2 participants