-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor copy change in rollback #6123
base: main
Are you sure you want to change the base?
Conversation
|
@@ -119,7 +119,7 @@ describe("rollback", () => { | |||
mockPostDeployment(); | |||
|
|||
mockPrompt({ | |||
text: "Please provide a message for this rollback (120 characters max, optional)?", | |||
text: "Please provide an optional message for this rollback (120 characters max)?", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this failed locally since we changed this messaging during review @CarmenPopoviciu but CI was passing?
Is CI not running this test for some reason or any idea why this passed?
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9619498719/npm-package-wrangler-6123 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6123/npm-package-wrangler-6123 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9619498719/npm-package-wrangler-6123 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9619498719/npm-package-create-cloudflare-6123 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9619498719/npm-package-cloudflare-kv-asset-handler-6123 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9619498719/npm-package-miniflare-6123 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9619498719/npm-package-cloudflare-pages-shared-6123 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9619498719/npm-package-cloudflare-vitest-pool-workers-6123 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
What this PR solves / how to test
Addressing product copy changes
(FYI: This PR is good to merge if a release is going out - just keeping open if product want further changes)
Author has addressed the following