Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor copy change in rollback #6123

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Minor copy change in rollback #6123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/wrangler/src/__tests__/rollback.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ describe("rollback", () => {
mockPostDeployment();

mockPrompt({
text: "Please provide a message for this rollback (120 characters max, optional)?",
text: "Please provide an optional message for this rollback (120 characters max)?",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this failed locally since we changed this messaging during review @CarmenPopoviciu but CI was passing?
Is CI not running this test for some reason or any idea why this passed?

result: "Test rollback",
});

Expand Down Expand Up @@ -168,7 +168,7 @@ describe("rollback", () => {
mockPostDeployment(true);

mockPrompt({
text: "Please provide a message for this rollback (120 characters max, optional)?",
text: "Please provide an optional message for this rollback (120 characters max)?",
result: "Test rollback",
});

Expand All @@ -180,7 +180,7 @@ describe("rollback", () => {
// We will have an additional confirmation
mockConfirm({
text:
"The following secrets have changed since the target version was deployed. Please confirm you wish to continue with the rollback" +
`The following secrets have changed since version rollback-version was deployed. Please confirm you wish to continue with the rollback` +
"\n * SECRET\n * SECRET_TWO",
result: true,
});
Expand Down
2 changes: 1 addition & 1 deletion packages/wrangler/src/versions/rollback/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ export async function versionsRollbackHandler(args: VersionsRollbackArgs) {
.split(", ");

const secretConfirmation = await confirm(
"The following secrets have changed since the target version was deployed. " +
`The following secrets have changed since version ${versionId} was deployed. ` +
`Please confirm you wish to continue with the rollback\n` +
changedSecrets.map((secret) => ` * ${secret}`).join("\n")
);
Expand Down
Loading