fix: try to serve assets from unencoded and encoded paths #6728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ec08675 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
emily-shen
force-pushed
the
emily/redirect-to-encoded
branch
from
18fecaf
to
f0266c3
Compare
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10961105486/npm-package-wrangler-6728You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6728/npm-package-wrangler-6728Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10961105486/npm-package-wrangler-6728 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10961105486/npm-package-create-cloudflare-6728 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10961105486/npm-package-cloudflare-kv-asset-handler-6728npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10961105486/npm-package-miniflare-6728npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10961105486/npm-package-cloudflare-pages-shared-6728npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10961105486/npm-package-cloudflare-vitest-pool-workers-6728npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10961105486/npm-package-cloudflare-workers-editor-shared-6728npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10961105486/npm-package-cloudflare-workers-shared-6728Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
emily-shen
commented
Sep 16, 2024
emily-shen
force-pushed
the
emily/redirect-to-encoded
branch
from
f0266c3
to
7781371
Compare
GregBrimble
reviewed
Sep 16, 2024
GregBrimble
approved these changes
Sep 19, 2024
emily-shen
force-pushed
the
emily/redirect-to-encoded
branch
3 times, most recently
from
b31019a
to
6416648
Compare
Co-authored-by: Greg Brimble <[email protected]>
petebacondarwin
approved these changes
Sep 20, 2024
CarmenPopoviciu
approved these changes
Sep 20, 2024
emily-shen
force-pushed
the
emily/redirect-to-encoded
branch
from
6416648
to
86a255f
Compare
petebacondarwin
approved these changes
Sep 20, 2024
GregBrimble
approved these changes
Sep 20, 2024
| finalPath: "/%5Bboop%5D/", | ||
| }, | ||
| { | ||
| title: "/[boop].html -> /%5Bboop%5D.html 307 (with /[boop].html)", |
There was a problem hiding this comment.
Good test, asserting the execution order!
| files: ["/[boop].html"], | ||
| requestPath: "/%5Bboop%5D", | ||
| }, | ||
| // encoding still operates when html_handling is set to 'none' |
| matchedFile: "/bin/index.html", | ||
| finalPath: "/bin/", | ||
| }, | ||
| // This is a bit rogue, but then so is the test case |
emily-shen
commented
Sep 20, 2024
| ), | ||
| hashPath(normalizeFilePath(relativeFilepath)), | ||
| // used absolute filepath here so that changes to the enclosing asset folder will be registered | ||
| hashPath(filepath + filestat.mtimeMs.toString()), |
There was a problem hiding this comment.
Note what goes into contentHash doesn't actually matter, as long as it is uniquely associated with that filepath and updates with file changes. Just removed the filepath encoding because it was unnecessary and because normalizeFilePath() expects a relative filepath now.
emily-shen
force-pushed
the
emily/redirect-to-encoded
branch
from
ef87321
to
ec08675
Compare
petebacondarwin
approved these changes
Sep 20, 2024
emily-shen
added
e2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test
Fixes WC-2693
Author has addressed the following