Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: try to serve assets from unencoded and encoded paths #6728

Merged
merged 7 commits into from
Sep 23, 2024
Merged

fix: try to serve assets from unencoded and encoded paths #6728

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ebf8367
remove encoding at upload
emily-shen Sep 19, 2024
3f57a43
add encoding redirect behaviour
emily-shen Sep 19, 2024
0a7e8c7
add and move test cases
emily-shen Sep 19, 2024
2721f86
pr feedback
emily-shen Sep 20, 2024
86a255f
changeset
emily-shen Sep 20, 2024
6860d95
fix and expand fixture tests
emily-shen Sep 20, 2024
ec08675
update changeset
emily-shen Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .changeset/shaggy-peas-notice.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
"@cloudflare/workers-shared": patch
"miniflare": patch
"wrangler": patch
---

fix: remove filepath encoding on asset upload and handle sometimes-encoded characters

Some characters like [ ] @ are encoded by encodeURIComponent() but are often requested at an unencoded filepath.
emily-shen marked this conversation as resolved.
Show resolved Hide resolved
This change will make assets with filenames with these characters accessible at both the encoded and unencoded paths,
but use the encoded path as the canonical one.
emily-shen marked this conversation as resolved.
Show resolved Hide resolved
Loading
Loading