Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a systemImagePullSecrets helm value #2920

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

georgethebeatle
Copy link
Member

Is there a related GitHub Issue?

No

What is this change about?

This value would allow the korifi api and controller images to be pulled from a
private registry. This can be useful in corporate environments if an internal
mirror registry is being used as well as in environments with no internet.

Does this PR introduce a breaking change?

No

Acceptance Steps

N/A

Tag your pair, your PM, and/or team

@cloudfoundry/wg-cf-on-k8s

This value would allow the korifi api and controller images to be pulled
from a private registry.
@georgethebeatle georgethebeatle marked this pull request as draft October 6, 2023 15:10
Copy link
Member

@julian-hj julian-hj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgethebeatle georgethebeatle marked this pull request as ready for review October 9, 2023 16:02
@georgethebeatle georgethebeatle merged commit 8a55c8c into main Oct 9, 2023
7 checks passed
@georgethebeatle georgethebeatle deleted the pr-system-image-pull-secrets branch October 9, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants