Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a systemImagePullSecrets helm value #2920

Merged
merged 1 commit into from
Oct 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.helm.md
Original file line number Diff line number Diff line change
Expand Up @@ -115,3 +115,4 @@ Here are all the values that can be set for the chart:
- `requests`: Resource requests.
- `cpu` (_String_): CPU request.
- `memory` (_String_): Memory request.
- `systemImagePullSecrets` (_Array_): List of `Secret` names to be used when pulling Korifi system images from private registries
4 changes: 4 additions & 0 deletions helm/korifi/api/rbac.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ metadata:
annotations:
eks.amazonaws.com/role-arn: {{ .Values.eksContainerRegistryRoleARN }}
{{- end }}
imagePullSecrets:
{{- range .Values.systemImagePullSecrets }}
- name: {{ . | quote }}
{{- end }}

---
apiVersion: rbac.authorization.k8s.io/v1
Expand Down
4 changes: 4 additions & 0 deletions helm/korifi/controllers/rbac.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ metadata:
annotations:
eks.amazonaws.com/role-arn: {{ .Values.eksContainerRegistryRoleARN }}
{{- end }}
imagePullSecrets:
{{- range .Values.systemImagePullSecrets }}
- name: {{ . | quote }}
{{- end }}

---
apiVersion: rbac.authorization.k8s.io/v1
Expand Down
7 changes: 7 additions & 0 deletions helm/korifi/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,13 @@
"type": "string"
}
},
"systemImagePullSecrets": {
"description": "List of `Secret` names to be used when pulling Korifi system images from private registries",
"type": "array",
"items": {
"type": "string"
}
},
"eksContainerRegistryRoleARN": {
"description": "Amazon Resource Name (ARN) of the IAM role to use to access the ECR registry from an EKS deployed Korifi. Required if containerRegistrySecret not set.",
"type": "string"
Expand Down
1 change: 1 addition & 0 deletions helm/korifi/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ containerRegistrySecrets:
- image-registry-credentials
eksContainerRegistryRoleARN: ""
containerRegistryCACertSecret:
systemImagePullSecrets: []

reconcilers:
build: kpack-image-builder
Expand Down