Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated .gitignore to ignore the certificates related files during development and testing #602

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

nekomeowww
Copy link
Contributor

What type of PR is this?

/kind design

What this PR does / why we need it:

During development and testing with either apiserver or clustersynchro-manager modules, temporary certificates will be generated and should never be committed, this Pull Request introduces to ignore a set of extensions of certificates related files in .gitignore.

Which issue(s) this PR fixes

None.

Special notes for your reviewer

Does this PR introduce a user-facing change?

None

…ring development and testing

Signed-off-by: Neko Ayaka <[email protected]>
@clusterpedia-bot
Copy link

Hi @nekomeowww,
Thanks for your pull request!
If the PR is ready, use the /auto-cc command to assign Reviewer to Review.
We will review it shortly.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@clusterpedia-bot
Copy link

@nekomeowww

Failed add label kind/design
Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@Iceber
Copy link
Member

Iceber commented Nov 27, 2023

good fix, avoid developers uploading certificates of test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants