cleanup and fixes

cms-l1-dpg · Oct 22, 2024 · b134ee3 · b134ee3
1 parent 9cc15a8
commit b134ee3
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 20 deletions.
diff --git a/configs/V44nano/object_performance/electron_iso.yaml b/configs/V44nano/object_performance/electron_iso.yaml
@@ -4,7 +4,7 @@ ElectronsIsolation_Barrel:
   match_test_to_ref: True
   iso_vs_efficiency: True
   reference_object:
-    GenPart:reference_electron:barrel: "pt"
+    GenPart:reference_electron_barrel: "pt"
   test_objects:
     L1tkElectron:NoIsoForIso: "relIso"
   xlabel: "Isolation"

diff --git a/configs/V44nano/object_performance/electron_trigger.yaml b/configs/V44nano/object_performance/electron_trigger.yaml
@@ -26,13 +26,6 @@ ElectronsTriggerEndcap:
   match_test_to_ref: True
   reference_object:
     GenPart:reference_electron_trigger_endcap: "pt"
-    cuts:
-      event:
-        - "(({statusFlags}>>7)&1) == 1"
-        - "abs({pdgId}) == 11"
-        - "abs({eta}) > 1.5"
-      object:
-        - "abs({eta}) < 2.8"
   test_objects:
     L1EG:default:endcap: "pt"
     L1tkElectron:NoIso:endcap: "pt"

diff --git a/configs/V44nano/objects/GenPart.yaml b/configs/V44nano/objects/GenPart.yaml
@@ -52,6 +52,17 @@ GenPart:
         object:
           inclusive:
             - "abs({eta}) < 2.4"
+    reference_electron_barrel:
+      label: "Gen Electron"
+      cuts:
+        event:
+          inclusive:
+            - "(({statusFlags}>>7)&1) == 1"
+            - "abs({pdgId}) == 11"
+            - "abs({eta}) < 1.479"
+        object:
+          inclusive:
+            - "abs({eta}) < 2.4"
     reference_electron:
       label: "Gen Electron"
       cuts:

diff --git a/configs/V44nano/objects/muons.yaml b/configs/V44nano/objects/muons.yaml
@@ -1,13 +1,3 @@
-GenPart:
-  label: "Gen Muon"
-  eta_ranges:
-    inclusive: [0, 7]
-  ids:
-    gen_electron_default:
-      cuts:
-        inclusive:
-          - "({statusFlags}>>7)&1 == 1"
-
 L1gmtTkMuon:
   label: "GMT TkMuon"
   match_dR: 0.1

diff --git a/menu_tools/object_performance/plotter.py b/menu_tools/object_performance/plotter.py
@@ -105,7 +105,6 @@ def _save_json(self, file_name):
 
             xbins = self.turnon_collection.bins
             xbins = 0.5 * (xbins[1:] + xbins[:-1])
-            print(len(xbins))
 
             if self.cfg.iso_vs_eff_plot:
                 efficiency = self._get_iso_vs_eff_hist(gen_hist_trig[0])

diff --git a/menu_tools/utils/objects.py b/menu_tools/utils/objects.py
@@ -213,7 +213,7 @@ def trafo(self) -> Optional[str]:
         try:
             return self._object_params["trafo"]
         except KeyError:
-            print("No transformation defined in reference object")
+            # No transformation defined in reference object `self.object_key`
             return None
 
     def _get_cuts(self, event_or_object: str) -> dict[str, list[str]]: