-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VP78 Semi-Buff #135
VP78 Semi-Buff #135
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if the VP78 is available in the vendor. If it is, are you trying to make it more viable as a secondary or primary? Or something else? I'm a fan of balancing around how the weapon should perform if you were to compare it to a real firearm versus how it should perform based on some aspect of the game. The former is usually more objective and better longer-term, since other parts of the game can and usually do change.
.vscode/settings.json
Outdated
@@ -9,7 +9,7 @@ | |||
"**/.pnp.*": true | |||
}, | |||
"editor.codeActionsOnSave": { | |||
"source.fixAll.eslint": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably didn't mean to include this change. Some files get pushed to your branch because you changed somethinge elsewhere, but they aren't needed, like config files as the case is here. No big deal, you can just push a change that cancels this out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah uh what was this supposed to be...? send help...
code/datums/ammo/bullet/pistol.dm
Outdated
damage_falloff = DAMAGE_FALLOFF_TIER_3 //"VP78 - the only pistol viable as a primary."-Vampmare, probably. | ||
penetration = ARMOR_PENETRATION_TIER_2 | ||
shrapnel_chance = SHRAPNEL_CHANCE_TIER_1 | ||
damage_falloff = 0 //HESH round don't care about range! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really not sure about the no damage falloff here. I believe most ammo has damage falloff of some kind outside of sniper rifles. You can probably up it, but I would not leave it off for a handgun.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah definitely not zero falloff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aight, but I haven't been able to find the effective range stat. I'll make it in line with the rifles or something? I dunno.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see. I'm just... really really dumb. Standby.
accuracy_mult_unwielded = BASE_ACCURACY_MULT | ||
scatter = SCATTER_AMOUNT_TIER_6 | ||
burst_scatter_mult = SCATTER_AMOUNT_TIER_6 | ||
accuracy_mult_unwielded = BASE_ACCURACY_MULT + HIT_ACCURACY_MULT_TIER_7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be a bit much 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iirc the base to hit is like 30%?
wait is that unwielded im a friggin IDIOT AUGH-
it was supposed to be fore the wielded bonus
christ... pain.
Make it viable as a secondary I think. |
We could give it a TM tomorrow. I'm starting to form the opinion that setting damage_falloff to something like 2 or 3 might be fine enough to make the gun quite nice. |
About the pull request
VP78 now has NO FALLOFF, and is much more accurate. This means it should hopefully be more consistent and competitive. This is relatively minor because... well, I have bigger plans for later and I want to test the waters. Also because lol lmao new to github.
Explain why it's good for the game
VP78 is a joke rn, especially without attachments.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog