Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VP78 Semi-Buff #135

Merged
merged 9 commits into from
Mar 18, 2024
Merged

VP78 Semi-Buff #135

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9e7cf8a
first attempt if this fucks up ill be sad
Mar 4, 2024
3001673
ok hopefully this is fixes.
Mar 5, 2024
1cfd785
Merge branch 'master' into master
KoishiVibe Mar 5, 2024
6892663
Update settings.json
KoishiVibe Mar 5, 2024
98927e3
minor change of range and falloff
Mar 6, 2024
d1e2f07
Merge branch 'master' of https://github.com/KoishiVibe/PvE13KOISHI
Mar 6, 2024
3cd831c
Merge branch 'master' into master
KoishiVibe Mar 6, 2024
0b964c7
minor changes to the VP78 again...
Mar 6, 2024
ab93382
Merge branch 'master' into master
KoishiVibe Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"**/.pnp.*": true
},
"editor.codeActionsOnSave": {
"source.fixAll.eslint": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably didn't mean to include this change. Some files get pushed to your branch because you changed somethinge elsewhere, but they aren't needed, like config files as the case is here. No big deal, you can just push a change that cancels this out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah uh what was this supposed to be...? send help...

"source.fixAll.eslint": "explicit"
},
"files.eol": "\n",
"files.insertFinalNewline": true,
Expand Down
6 changes: 3 additions & 3 deletions code/datums/ammo/bullet/pistol.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,9 +182,9 @@

accuracy = HIT_ACCURACY_TIER_2
damage = 50
penetration = ARMOR_PENETRATION_TIER_4
shrapnel_chance = SHRAPNEL_CHANCE_TIER_2
damage_falloff = DAMAGE_FALLOFF_TIER_3 //"VP78 - the only pistol viable as a primary."-Vampmare, probably.
penetration = ARMOR_PENETRATION_TIER_2
shrapnel_chance = SHRAPNEL_CHANCE_TIER_1
damage_falloff = 0 //HESH round don't care about range!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really not sure about the no damage falloff here. I believe most ammo has damage falloff of some kind outside of sniper rifles. You can probably up it, but I would not leave it off for a handgun.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah definitely not zero falloff.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aight, but I haven't been able to find the effective range stat. I'll make it in line with the rifles or something? I dunno.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see. I'm just... really really dumb. Standby.


/datum/ammo/bullet/pistol/squash/toxin
name = "toxic squash-head pistol bullet"
Expand Down
12 changes: 6 additions & 6 deletions code/modules/projectiles/guns/pistols.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,7 +677,7 @@
damage_mult = BASE_BULLET_DAMAGE_MULT + BULLET_DAMAGE_MULT_TIER_4

//-------------------------------------------------------
//VP78 - the only pistol viable as a primary.
//VP78 - High power pistol?

/obj/item/weapon/gun/pistol/vp78
name = "\improper VP78 pistol"
Expand Down Expand Up @@ -717,13 +717,13 @@

/obj/item/weapon/gun/pistol/vp78/set_gun_config_values()
..()
set_fire_delay(FIRE_DELAY_TIER_4)
set_fire_delay(FIRE_DELAY_TIER_6)
set_burst_amount(BURST_AMOUNT_TIER_3)
set_burst_delay(FIRE_DELAY_TIER_11)
set_burst_delay(FIRE_DELAY_TIER_12)
accuracy_mult = BASE_ACCURACY_MULT
accuracy_mult_unwielded = BASE_ACCURACY_MULT
scatter = SCATTER_AMOUNT_TIER_6
burst_scatter_mult = SCATTER_AMOUNT_TIER_6
accuracy_mult_unwielded = BASE_ACCURACY_MULT + HIT_ACCURACY_MULT_TIER_7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be a bit much 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc the base to hit is like 30%?
wait is that unwielded im a friggin IDIOT AUGH-
it was supposed to be fore the wielded bonus

christ... pain.

scatter = SCATTER_AMOUNT_TIER_9
burst_scatter_mult = SCATTER_AMOUNT_TIER_7
scatter_unwielded = SCATTER_AMOUNT_TIER_6
damage_mult = BASE_BULLET_DAMAGE_MULT
recoil = RECOIL_AMOUNT_TIER_5
Expand Down
Loading