Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W-Y platoon #136

Draft
wants to merge 76 commits into
base: master
Choose a base branch
from
Draft

W-Y platoon #136

wants to merge 76 commits into from

Conversation

bearrrrrrrr
Copy link
Contributor

@bearrrrrrrr bearrrrrrrr commented Mar 4, 2024

About the pull request

TAKEN OVER BY ANDRO THE BETEL!

WY Platoon AZURE-15

new map - USCSS Apostasy
new guns - m39 duplex, M240 firing globs
new platoon - pmc's

Explain why it's good for the game

wy and wy pmcs are quite prominent in the aliens lore and could offer gms and players more opportunities for cool stories and roleplay

@morrowwolf morrowwolf marked this pull request as draft March 4, 2024 19:27
@morrowwolf
Copy link
Member

Hit "ready for review" when you're ready for review

code/game/jobs/job/marine/squads.dm Outdated Show resolved Hide resolved
@DexterDude DexterDude self-requested a review April 30, 2024 01:00
Copy link
Contributor

@DexterDude DexterDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Map review time!!!

This is just an initial review, going to do a deeper check in a few when I have more free time.

  • I think the singularity part of the map being present is weird. Generally shipmaps try to imply that the ship is much larger than the map actually is. Singularity being present in a hangar bay is a bit odd.
  • should have vendors for coffee/cigarettes for rp
  • hangar is too cramped, it needs a bit more space to allow for a large vehicle to get around the hangar bay and enter through the back without having to drive over the landing pad, just in case GMs decide to use a larger dropship.
  • Map has no real cargo area for incoming equipment and also has no launch pad & computer

reviewspot1

reviewspot2

reviewspot3

reviewspot4

reviewspot5

reviewspot6

if you disagree with any of this (like if you believe certain things are intentional) do let me know

@DexterDude
Copy link
Contributor

DexterDude commented Apr 30, 2024

forgot to mention, but this podlock south-east in the hangar is also un-named, should be named hangar lockdown or something similar

hangardoors

layering here is also bad, I would suggest using a design like the last image or similar using autoturf strata grass and beach sand in the corner, because lizards like sand i think

layeringbad

mapdesign

@AndroBetel
Copy link
Contributor

map review changes done

Copy link

github-actions bot commented May 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

github-actions bot commented May 2, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@DexterDude
Copy link
Contributor

Still need to do an in depth review, but you did miss the area around the W-Y logo in the canteen. It needs the rounded corners.

ghost pushed a commit that referenced this pull request May 23, 2024
Copy link

github-actions bot commented Jun 6, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Contributor

@Doubleumc Doubleumc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change dropship name to something other than "Orphan Stomper". Too goofy. Suggestions: "Problem Solver", "Guns For Hire", "Peacemaker", "Breadwinner", "Cash Flow" -- anything you could put on a financial report and not get yelled at by the director.

Other than that, looks good to me.

@KoishiVibe
Copy link
Contributor

Change dropship name to something other than "Orphan Stomper". Too goofy. Suggestions: "Problem Solver", "Guns For Hire", "Peacemaker", "Breadwinner", "Cash Flow" -- anything you could put on a financial report and not get yelled at by the director.

Other than that, looks good to me.

Probably could also toss some edge in there. Reaper's Stockbroker, whatever.

@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Doubleumc
Copy link
Contributor

Feel free to reopen when the issues have been addressed.

@Doubleumc Doubleumc marked this pull request as draft August 15, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants