Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Machetes on back for smartgunners #177

Merged
merged 6 commits into from
Apr 7, 2024

Conversation

grifp71
Copy link
Contributor

@grifp71 grifp71 commented Mar 24, 2024

https://youtu.be/hXv3fqUwCcg?t=30

Allows smartgunners to utilize the backslot PURELY for weapons by proccing for weapon/gun.

This has been suggested for months because you see Drake switch to a M240 in the movie. I have mained smartgunner pretty frequently on PvE (I nearly have my gold medal). I was initially opposed to the idea, but people keep asking for it - and people keep saying they're going to work on it, but nobody has and it keeps coming up, so I figured I'd take my first deep dive into coding beyond super simple edits and do it.

Now, I was initially opposed to this idea because I don't want to see smartgunners overshadow the other classes, but I'm not so sure it will be that big of a deal. If you take extra ammo for anything that isn't a SG, you're gimping your storage horribly. I like this for emergency situations and when everything is going to hell - just like Drake in the movie. The smartgun honestly starts to feel a bit anemic compared to the M41, so this adds a slight bit more pizazz to the role. (the volume of fire is nice, but holy hell does the M41 drop a xenoid faster)

Potential cons are smartgunners hogging the M37 and M240, but any squad sergeant or gunny worth their salt should smoke them if that happens, and honestly.. a lot of the time our riflemen fail to even carry the special weapons in the first place, so I guess if they won't take them, it's better to have them on the back of a smartgunner for situational use.

Now, I'm not smug enough to say that I think this should be merged for certain. As the author of this PR, I heavily advocate a test merge and see how it goes in actual gameplay. If it becomes a monster or people are stupid with it, we can can the idea and I'll be the first to agree. But I think it's movielike and has some soul, and our population is probably mature enough to handle it without hogging shit.

Tested locally, works, and of course smartgunners can still not wear satchels or backpacks.

Real credit goes to Andro for helping guide me through my first code dive. Thanks.

@KoishiVibe
Copy link
Contributor

The smartgun is supposed to holster to the back anyways. What about holstering the smartgun to the back and letting the suit slot take some small pouches such as for pistol ammo, or a pistol holster, or just the pistol itself?

@grifp71
Copy link
Contributor Author

grifp71 commented Mar 25, 2024

The smartgun is supposed to holster to the back anyways. What about holstering the smartgun to the back and letting the suit slot take some small pouches such as for pistol ammo, or a pistol holster, or just the pistol itself?

don't want to give them more storage and morrow is also very anti-storage

@KoishiVibe
Copy link
Contributor

The smartgun is supposed to holster to the back anyways. What about holstering the smartgun to the back and letting the suit slot take some small pouches such as for pistol ammo, or a pistol holster, or just the pistol itself?

don't want to give them more storage and morrow is also very anti-storage

In that case, then just a pistol or the sidearm pouch then?

@@ -424,6 +424,10 @@
if(slot != WEAR_BACK)
return


if(istype(equipping_item, /obj/item/weapon/gun))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a list of allowed types that it cycles through on the smartgun rather than directly coded in for future maintainability.

@morrowwolf
Copy link
Member

Not 100% sure about this one. I uuuh... eeeh? I'll think on it.

@morrowwolf morrowwolf marked this pull request as draft March 25, 2024 19:57
@KoishiVibe
Copy link
Contributor

if this doesn't go through, could I borrow some of the code?

@morrowwolf
Copy link
Member

Waiting on requested changes still.

@grifp71 grifp71 marked this pull request as ready for review April 1, 2024 20:54
@morrowwolf morrowwolf marked this pull request as draft April 6, 2024 01:25
@grifp71 grifp71 marked this pull request as ready for review April 6, 2024 03:55
@morrowwolf morrowwolf changed the title Drakemaxxing or weapons on back for smartgunners Machetes on back for smartgunners Apr 7, 2024
@morrowwolf morrowwolf enabled auto-merge (squash) April 7, 2024 23:04
@morrowwolf morrowwolf merged commit 1a5b544 into cmss13-devs:master Apr 7, 2024
34 checks passed
AmoryBlaine added a commit to AmoryBlaine/PvE-CMSS13 that referenced this pull request Apr 10, 2024
commit 6392549
Merge: 5c27cc6 72a1e3f
Author: AmoryBlaine <[email protected]>
Date:   Tue Apr 9 23:38:50 2024 -0400

    Merge branch 'PvE-CMSS13:master' into master

commit 72a1e3f
Author: KoishiVibe <[email protected]>
Date:   Tue Apr 9 21:04:11 2024 -0500

    more fluff, removes kevlar mentions and replaces with venlar (cmss13-devs#188)

    Co-authored-by: KoishiVibe <[email protected]>
    Co-authored-by: morrowwolf <[email protected]>

commit 0c61b76
Author: DexterDude <[email protected]>
Date:   Tue Apr 9 21:24:46 2024 -0400

    M44 sprite and sound changes (cmss13-devs#196)

commit 4475857
Author: morrowwolf <[email protected]>
Date:   Tue Apr 9 21:22:51 2024 -0400

    Medals (cmss13-devs#222)

commit 4020295
Author: grifp71 <[email protected]>
Date:   Tue Apr 9 21:22:20 2024 -0400

    Biblically Accurate Smartguns (cmss13-devs#213)

    Co-authored-by: morrow <[email protected]>

commit 5c27cc6
Merge: 298847c 0976be2
Author: AmoryBlaine <[email protected]>
Date:   Mon Apr 8 17:13:21 2024 -0400

    Merge branch 'PvE-CMSS13:master' into master

commit 0976be2
Author: AndroBetel <[email protected]>
Date:   Mon Apr 8 23:30:12 2024 +0300

    machetes now have belt slot sprites (cmss13-devs#224)

    Fix for a previously invisible belt scabbard.

commit 1a5b544
Author: grifp71 <[email protected]>
Date:   Sun Apr 7 19:15:10 2024 -0400

    Machetes on back for smartgunners (cmss13-devs#177)

commit 784a01f
Author: AmoryBlaine <[email protected]>
Date:   Sat Apr 6 19:00:35 2024 -0400

    Fixes horizontal access denied sprite (cmss13-devs#218)

    Horizontal fix.

commit c91382d
Author: Nihisohel <[email protected]>
Date:   Sun Apr 7 00:03:12 2024 +0800

    Tactical reload on the move (cmss13-devs#217)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants